Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 21, 2016

What changes were proposed in this pull request?

This patch moves native command and script transformation into SparkSqlAstBuilder. This builds on #12561. See the last commit for diff.

How was this patch tested?

Updated test cases to reflect this.

@yhuai
Copy link
Contributor

yhuai commented Apr 21, 2016

d813783 looks good

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56497 has finished for PR 12564 at commit 5e99598.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56506 has finished for PR 12564 at commit ecc9ea7.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #2840 has finished for PR 12564 at commit ecc9ea7.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56557 has finished for PR 12564 at commit a38eaf1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56571 has finished for PR 12564 at commit 21b5397.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56576 has finished for PR 12564 at commit 81c9dbd.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • implicit class SchemaAttribute(f: CatalogColumn)

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #2849 has finished for PR 12564 at commit 21b5397.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Apr 21, 2016

LGTM

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56587 has finished for PR 12564 at commit 1356aa0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Apr 21, 2016

Merging in master.

@asfgit asfgit closed this in 1a95397 Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants