Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 21, 2016

What changes were proposed in this pull request?

This patch builds on #12556 and completely removes the use of Hive's variable substitution.

How was this patch tested?

Covered by existing tests.

@yhuai
Copy link
Contributor

yhuai commented Apr 21, 2016

c878aef looks good

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56490 has finished for PR 12561 at commit c878aef.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class HiveSqlParser(conf: SQLConf) extends AbstractSqlParser

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #2841 has finished for PR 12561 at commit 8864f2a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56507 has finished for PR 12561 at commit 8864f2a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56504 has finished for PR 12561 at commit 737ea41.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Apr 21, 2016

LGTM

@rxin
Copy link
Contributor Author

rxin commented Apr 21, 2016

Merging in master.

@asfgit asfgit closed this in 3a21e8d Apr 21, 2016
@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56555 has finished for PR 12561 at commit f74b381.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants