Skip to content

Commit efd019b

Browse files
eval() and toString() bug fixes.
1 parent 7d81e95 commit efd019b

File tree

1 file changed

+5
-5
lines changed
  • sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions

1 file changed

+5
-5
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ case class Case(key: Option[Expression], branches: Seq[Expression]) extends Expr
250250
case (Some(x), _) =>
251251
Some(x)
252252
case (None, Seq(cond, value)) =>
253-
if (cond.eval(input) == true) Some(value.eval(input)) else None
253+
if (cond.eval(input) == expectedVal) Some(value.eval(input)) else None
254254
case (None, Seq(elseValue)) =>
255255
Some(elseValue.eval(input))
256256
}.getOrElse(null)
@@ -272,14 +272,14 @@ case class Case(key: Option[Expression], branches: Seq[Expression]) extends Expr
272272
val keyString = key.get.toString
273273
firstBranch = s"if ($keyString == ${branches(0)}) { ${branches(1)} }"
274274
otherBranches = branches.sliding(2, 2).drop(1).map {
275-
case Seq(cond, value) => s"\nelse if ($keyString == $cond) { $value }"
276-
case Seq(elseValue) => s"\nelse { $elseValue }"
275+
case Seq(cond, value) => s" else if ($keyString == $cond) { $value }"
276+
case Seq(elseValue) => s" else { $elseValue }"
277277
}.mkString
278278
} else {
279279
firstBranch = s"if (${branches(0)}) { ${branches(1)} }"
280280
otherBranches = branches.sliding(2, 2).drop(1).map {
281-
case Seq(cond, value) => s"\nelse if ($cond) { $value }"
282-
case Seq(elseValue) => s"\nelse { $elseValue }"
281+
case Seq(cond, value) => s" else if ($cond) { $value }"
282+
case Seq(elseValue) => s" else { $elseValue }"
283283
}.mkString
284284
}
285285
firstBranch ++ otherBranches

0 commit comments

Comments
 (0)