Don't go overboard with escaping

andrewor14 · andrewor14 · commit ed0149109064 · 2014-07-24T18:49:00.000-07:00
diff --git a/core/src/main/scala/org/apache/spark/util/Utils.scala b/core/src/main/scala/org/apache/spark/util/Utils.scala
@@ -1312,7 +1312,7 @@ private[spark] object Utils extends Logging {
   def sparkJavaOpts(conf: SparkConf, filterKey: (String => Boolean) = _ => true): Seq[String] = {
     conf.getAll
       .filter { case (k, _) => filterKey(k) }
-      .map { case (k, v) => "-D" + k + "=\\\"" + v + "\\\"" }
+      .map { case (k, v) => s"-D$k=$v" }
   }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -1312,7 +1312,7 @@ private[spark] object Utils extends Logging {`
`1312`	`1312`	`def sparkJavaOpts(conf: SparkConf, filterKey: (String => Boolean) = _ => true): Seq[String] = {`
`1313`	`1313`	`conf.getAll`
`1314`	`1314`	`.filter { case (k, _) => filterKey(k) }`
`1315`		`- .map { case (k, v) => "-D" + k + "=\\\"" + v + "\\\"" }`
	`1315`	`+ .map { case (k, v) => s"-D$k=$v" }`
`1316`	`1316`	`}`
`1317`	`1317`
`1318`	`1318`	`}`