Skip to content

Commit e3b7bb4

Browse files
gengliangwangHyukjinKwon
authored andcommitted
[SPARK-24811][FOLLOWUP][SQL] Revise package of AvroDataToCatalyst and CatalystDataToAvro
## What changes were proposed in this pull request? In #21838, the class `AvroDataToCatalyst` and `CatalystDataToAvro` were put in package `org.apache.spark.sql`. They should be moved to package `org.apache.spark.sql.avro`. Also optimize imports in Avro module. ## How was this patch tested? Unit test Closes #22196 from gengliangwang/avro_revise_package_name. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: hyukjinkwon <[email protected]>
1 parent 8cc591c commit e3b7bb4

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515
* limitations under the License.
1616
*/
1717

18-
package org.apache.spark.sql
18+
package org.apache.spark.sql.avro
1919

2020
import org.apache.avro.Schema
2121
import org.apache.avro.generic.GenericDatumReader
2222
import org.apache.avro.io.{BinaryDecoder, DecoderFactory}
2323

24-
import org.apache.spark.sql.avro.{AvroDeserializer, SchemaConverters}
2524
import org.apache.spark.sql.catalyst.expressions.{ExpectsInputTypes, Expression, UnaryExpression}
2625
import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, CodeGenerator, ExprCode}
2726
import org.apache.spark.sql.types.{AbstractDataType, BinaryType, DataType}

external/avro/src/main/scala/org/apache/spark/sql/avro/CatalystDataToAvro.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,15 @@
1515
* limitations under the License.
1616
*/
1717

18-
package org.apache.spark.sql
18+
package org.apache.spark.sql.avro
1919

2020
import java.io.ByteArrayOutputStream
2121

2222
import org.apache.avro.generic.GenericDatumWriter
2323
import org.apache.avro.io.{BinaryEncoder, EncoderFactory}
2424

25-
import org.apache.spark.sql.avro.{AvroSerializer, SchemaConverters}
2625
import org.apache.spark.sql.catalyst.expressions.{Expression, UnaryExpression}
27-
import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, CodeGenerator, ExprCode}
26+
import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, ExprCode}
2827
import org.apache.spark.sql.types.{BinaryType, DataType}
2928

3029
case class CatalystDataToAvro(child: Expression) extends UnaryExpression {

external/avro/src/test/scala/org/apache/spark/sql/avro/AvroCatalystDataConversionSuite.scala

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,12 @@
1717

1818
package org.apache.spark.sql.avro
1919

20-
import org.apache.avro.Schema
21-
2220
import org.apache.spark.SparkFunSuite
23-
import org.apache.spark.sql.{AvroDataToCatalyst, CatalystDataToAvro, RandomDataGenerator}
21+
import org.apache.spark.sql.RandomDataGenerator
2422
import org.apache.spark.sql.catalyst.{CatalystTypeConverters, InternalRow}
2523
import org.apache.spark.sql.catalyst.expressions.{ExpressionEvalHelper, GenericInternalRow, Literal}
2624
import org.apache.spark.sql.catalyst.util.{ArrayBasedMapData, GenericArrayData, MapData}
2725
import org.apache.spark.sql.types._
28-
import org.apache.spark.unsafe.types.UTF8String
2926

3027
class AvroCatalystDataConversionSuite extends SparkFunSuite with ExpressionEvalHelper {
3128

0 commit comments

Comments
 (0)