[SPARK-54554][SQL] Fix CommandResult DPP tests and cleanup

- Removed latent attempt code causing test failures
- Updated test name to reflect Jira ticket
- Corrected wrong df values in DynamicPartitionPruningSuite

Author: dwsmith1983

debug_dpp.scala

@@ -0,0 +1,56 @@
+import org.apache.spark.sql.SparkSession
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.functions.max
+
+val spark = SparkSession.builder()
+  .appName("Debug DPP")
+  .master("local[*]")
+  .config("spark.sql.optimizer.dynamicPartitionPruning.enabled", "true")
+  .config("spark.sql.optimizer.dynamicPartitionPruning.reuseBroadcastOnly", "true")
+  .getOrCreate()
+
+// Create test data
+spark.sql("DROP TABLE IF EXISTS fact_stats")
+spark.sql("""
+  CREATE TABLE fact_stats (
+    date_id INT,
+    product_id INT,
+    units_sold INT,
+    store_id INT
+  )
+  PARTITIONED BY (store_id)
+""")
+
+// Insert some data
+(1 to 25).foreach { storeId =>
+  spark.sql(s"INSERT INTO fact_stats VALUES (1300, 1, 50, $storeId)")
+}
+
+// Test the DPP with CommandResult
+val maxPartitionDF = spark.sql("SHOW PARTITIONS fact_stats")
+  .agg(max("partition").alias("max_partition"))
+  .selectExpr("split(max_partition, '=')[1] as max_store_id")
+
+maxPartitionDF.createOrReplaceTempView("max_partition")
+
+val df = spark.sql("""
+  SELECT f.date_id, f.product_id, f.store_id, f.units_sold
+  FROM fact_stats f
+  JOIN max_partition m ON f.store_id = m.max_store_id
+""")
+
+println("=== Analyzed Plan ===")
+println(df.queryExecution.analyzed)
+
+println("\n=== Optimized Plan ===")
+println(df.queryExecution.optimizedPlan)
+
+println("\n=== Physical Plan ===")
+println(df.queryExecution.executedPlan)
+
+// Check if optimized plan contains DPP
+val optimizedPlan = df.queryExecution.optimizedPlan.toString()
+println(s"\nContains 'DynamicPruningSubquery': ${optimizedPlan.contains("DynamicPruningSubquery")}")
+println(s"Contains 'dynamicpruning': ${optimizedPlan.contains("dynamicpruning")}")
+
+spark.stop()

sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala

@@ -218,11 +218,9 @@ object PartitionPruning extends Rule[LogicalPlan] with PredicateHelper with Join
    * meet the following requirements:
    *   (1) it can not be a stream
    *   (2) it needs to contain a selective predicate used for filtering
-   *   (3) it should not be a metadata only operation
    */
   private def hasPartitionPruningFilter(plan: LogicalPlan): Boolean = {
     !plan.isStreaming &&
-    !plan.exists(_.isInstanceOf[CommandResult])  &&
     hasSelectivePredicate(plan)
   }
 

sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala

@@ -1822,7 +1822,7 @@ class DynamicPartitionPruningV1SuiteAEOn extends DynamicPartitionPruningV1Suite
     }
   }
 
-  test("DPP with CommandResult from SHOW PARTITIONS in broadcast join") {
+  test("SPARK-54554: DPP with CommandResult from SHOW PARTITIONS in broadcast join") {
     withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true",
         SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "true") {
       // Get max partition from SHOW PARTITIONS (CommandResult)
@@ -1844,7 +1844,7 @@ class DynamicPartitionPruningV1SuiteAEOn extends DynamicPartitionPruningV1Suite
       checkPartitionPruningPredicate(df, false, true)
 
       checkAnswer(df,
-        Row(1300, 1, 25, 50) :: Nil
+        Row(1150, 1, 9, 20) :: Nil
       )
 
       // Verify DPP predicates exist in the optimized logical plan