Skip to content

Commit cc309b0

Browse files
committed
address reviews
1 parent 187ff9a commit cc309b0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ class UDFRegistration private[sql] (functionRegistry: FunctionRegistry) extends
5858
| pythonIncludes: ${udf.func.pythonIncludes}
5959
| pythonExec: ${udf.func.pythonExec}
6060
| dataType: ${udf.dataType}
61+
| udfDeterministic: ${udf.udfDeterministic}
6162
""".stripMargin)
6263

6364
functionRegistry.createOrReplaceTempFunction(name, udf.builder)

sql/core/src/main/scala/org/apache/spark/sql/execution/python/PythonUDF.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ case class PythonUDF(
3030
dataType: DataType,
3131
children: Seq[Expression],
3232
evalType: Int,
33-
udfDeterministic: Boolean = true)
33+
udfDeterministic: Boolean)
3434
extends Expression with Unevaluable with NonSQLExpression with UserDefinedExpression {
3535

36-
override lazy val deterministic = udfDeterministic && children.forall(_.deterministic)
36+
override lazy val deterministic: Boolean = udfDeterministic && children.forall(_.deterministic)
3737

3838
override def toString: String = s"$name(${children.mkString(", ")})"
3939

0 commit comments

Comments
 (0)