Skip to content

Commit c6a6e3e

Browse files
committed
fix code style
1 parent 3214e0a commit c6a6e3e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,6 @@ trait HiveTypeCoercion {
361361
DecimalType(min(p1 - s1, p2 - s2) + max(s1, s2), max(s1, s2))
362362
)
363363

364-
// Cast is not needed for binary comparison
365364
case LessThan(e1 @ DecimalType.Expression(p1, s1),
366365
e2 @ DecimalType.Expression(p2, s2)) if p1 != p2 || s1 != s2 =>
367366
LessThan(Cast(e1, DecimalType.Unlimited), Cast(e2, DecimalType.Unlimited))

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,12 @@ class DecimalPrecisionSuite extends FunSuite with BeforeAndAfter {
5050
}
5151

5252
private def checkComparison(expression: Expression, expectedType: DataType): Unit = {
53-
val plan = Project(Seq(Alias(expression, "c")()), relation)
54-
val comparison = analyzer(plan).expressions(0).children(0).asInstanceOf[BinaryComparison]
55-
assert(comparison.left.dataType === expectedType)
56-
assert(comparison.right.dataType === expectedType)
53+
val plan = Project(Alias(expression, "c")() :: Nil, relation)
54+
val comparison = analyzer(plan).collect {
55+
case Project(Alias(e: BinaryComparison, _) :: Nil, _) => e
56+
}.head
57+
assert(comparison.left.dataType === expectedType)
58+
assert(comparison.right.dataType === expectedType)
5759
}
5860

5961
test("basic operations") {

0 commit comments

Comments
 (0)