Skip to content

Commit c466de6

Browse files
committed
Addresses comments
1 parent bc3f9b4 commit c466de6

File tree

3 files changed

+13
-32
lines changed

3 files changed

+13
-32
lines changed

sql/core/src/main/java/org/apache/spark/sql/sources/PartitioningOptions.java

Lines changed: 0 additions & 28 deletions
This file was deleted.

sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ private[spark] object SQLConf {
6666
// to its length exceeds the threshold.
6767
val SCHEMA_STRING_LENGTH_THRESHOLD = "spark.sql.sources.schemaStringLengthThreshold"
6868

69-
// Whether to perform partition discovery when loading external data sources.
69+
// Whether to perform partition discovery when loading external data sources. Default to true.
7070
val PARTITION_DISCOVERY_ENABLED = "spark.sql.sources.partitionDiscovery.enabled"
7171

7272
// Whether to perform eager analysis when constructing a dataframe.

sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import org.apache.spark.deploy.SparkHadoopUtil
2626
import org.apache.spark.rdd.RDD
2727
import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression}
2828
import org.apache.spark.sql.types.{StructField, StructType}
29-
import org.apache.spark.sql.{DataFrame, Row, SQLContext, SaveMode}
29+
import org.apache.spark.sql._
3030

3131
/**
3232
* ::DeveloperApi::
@@ -338,9 +338,16 @@ abstract class FSBasedRelation private[sql](
338338
private var _partitionSpec: PartitionSpec = maybePartitionSpec.map { spec =>
339339
spec.copy(partitionColumns = spec.partitionColumns.asNullable)
340340
}.getOrElse {
341-
discoverPartitions()
341+
if (partitionDiscoverEnabled()) {
342+
discoverPartitions()
343+
} else {
344+
PartitionSpec(StructType(Nil), Array.empty[Partition])
345+
}
342346
}
343347

348+
private def partitionDiscoverEnabled() =
349+
sqlContext.conf.getConf(SQLConf.PARTITION_DISCOVERY_ENABLED, "true").toBoolean
350+
344351
private[sql] def partitionSpec: PartitionSpec = _partitionSpec
345352

346353
/**
@@ -349,7 +356,9 @@ abstract class FSBasedRelation private[sql](
349356
def partitionColumns: StructType = partitionSpec.partitionColumns
350357

351358
private[sql] def refresh(): Unit = {
352-
_partitionSpec = discoverPartitions()
359+
if (partitionDiscoverEnabled()) {
360+
_partitionSpec = discoverPartitions()
361+
}
353362
}
354363

355364
private def discoverPartitions(): PartitionSpec = {

0 commit comments

Comments
 (0)