Skip to content

Commit be99eb3

Browse files
committed
Fix tests to not include multi-line configs
1 parent bd0d468 commit be99eb3

File tree

3 files changed

+1
-33
lines changed

3 files changed

+1
-33
lines changed

bin/run-tests

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,6 @@ for delimiter in "${delimiters[@]}"; do
173173
"-Dstraw=\"berry space\" -Dblue=\"berry \\\"quotes\\\"\" -Dblack=\"berry \\\\backslashes\\\\ \""
174174
test_parse_java_property "spark.$delimiter.10" \
175175
"-Dstraw=\"berry space\" -Dblue=\"berry \\\"quotes\\\"\" -Dblack=\"berry \\\\backslashes\\\\ \"" IGNORE_WHITESPACE
176-
test_parse_java_property "spark.$delimiter.11" \
177-
"-Dstraw=\"berry space\" -Dblue=\"berry \\\"quotes\\\"\" -Dblack=\"berry \\\\backslashes\\\\ \" -Dcherry=berry" IGNORE_WHITESPACE
178-
test_parse_java_property "spark.$delimiter.12" \
179-
"-Dstraw=\"berry space\" -Dblue=\"berry \\\"quotes\\\"\" -Dblack=\"berry \\\\backslashes\\\\ \" -Dcherry=berry" IGNORE_WHITESPACE
180176
done
181177
log_error
182178

@@ -197,10 +193,6 @@ test_split_java_options "spark.space.9" 3 \
197193
"-Dstraw=berry space" "-Dblue=berry \"quotes\"" "-Dblack=berry \\backslashes\\ "
198194
test_split_java_options "spark.space.10" 3 \
199195
"-Dstraw=berry space" "-Dblue=berry \"quotes\"" "-Dblack=berry \\backslashes\\ "
200-
test_split_java_options "spark.space.11" 4 \
201-
"-Dstraw=berry space" "-Dblue=berry \"quotes\"" "-Dblack=berry \\backslashes\\ " "-Dcherry=berry"
202-
test_split_java_options "spark.space.12" 4 \
203-
"-Dstraw=berry space" "-Dblue=berry \"quotes\"" "-Dblack=berry \\backslashes\\ " "-Dcherry=berry"
204196
log_error
205197

206198
# Test quote_java_property. Note that this relies on split_java_options to work correctly.
@@ -220,10 +212,6 @@ test_quote_java_property "spark.space.9" 3 \
220212
"\"-Dstraw=berry space\"" "\"-Dblue=berry \"quotes\"\"" "\"-Dblack=berry \\backslashes\\ \""
221213
test_quote_java_property "spark.space.10" 3 \
222214
"\"-Dstraw=berry space\"" "\"-Dblue=berry \"quotes\"\"" "\"-Dblack=berry \\backslashes\\ \""
223-
test_quote_java_property "spark.space.11" 4 \
224-
"\"-Dstraw=berry space\"" "\"-Dblue=berry \"quotes\"\"" "\"-Dblack=berry \\backslashes\\ \"" "\"-Dcherry=berry\""
225-
test_quote_java_property "spark.space.12" 4 \
226-
"\"-Dstraw=berry space\"" "\"-Dblue=berry \"quotes\"\"" "\"-Dblack=berry \\backslashes\\ \"" "\"-Dcherry=berry\""
227215
log_error
228216

229217
# Final test result

bin/test.conf

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,6 @@ spark.space.7 -Dstraw=berry -Dblue=berry -Dblack=berry
1818
spark.space.8 -Dstraw="berry space" -Dblue="berry" -Dblack=berry
1919
spark.space.9 -Dstraw="berry space" -Dblue="berry \"quotes\"" -Dblack="berry \\backslashes\\ "
2020
spark.space.10 -Dstraw="berry space" -Dblue="berry \"quotes\"" -Dblack="berry \\backslashes\\ "
21-
spark.space.11 \
22-
-Dstraw="berry space" \
23-
-Dblue="berry \"quotes\"" \
24-
-Dblack="berry \\backslashes\\ " \
25-
-Dcherry=berry
26-
spark.space.12 -Dstraw="berry space" -Dblue="berry \"quotes\"" \
27-
-Dblack="berry \\backslashes\\ " -Dcherry=berry
2821

2922
# Equal sign delimiter
3023
spark.equal.1=-Dstraw=berry
@@ -37,13 +30,6 @@ spark.equal.7=-Dstraw=berry -Dblue=berry -Dblack=berry
3730
spark.equal.8=-Dstraw="berry space" -Dblue="berry" -Dblack=berry
3831
spark.equal.9=-Dstraw="berry space" -Dblue="berry \"quotes\"" -Dblack="berry \\backslashes\\ "
3932
spark.equal.10 = -Dstraw="berry space" -Dblue="berry \"quotes\"" -Dblack="berry \\backslashes\\ "
40-
spark.equal.11=\
41-
-Dstraw="berry space" \
42-
-Dblue="berry \"quotes\"" \
43-
-Dblack="berry \\backslashes\\ " \
44-
-Dcherry=berry
45-
spark.equal.12=-Dstraw="berry space" -Dblue="berry \"quotes\"" \
46-
-Dblack="berry \\backslashes\\ " -Dcherry=berry
4733

4834
# Colon delimiter
4935
spark.colon.1:-Dstraw=berry
@@ -56,11 +42,4 @@ spark.colon.7:-Dstraw=berry -Dblue=berry -Dblack=berry
5642
spark.colon.8:-Dstraw="berry space" -Dblue="berry" -Dblack=berry
5743
spark.colon.9:-Dstraw="berry space" -Dblue="berry \"quotes\"" -Dblack="berry \\backslashes\\ "
5844
spark.colon.10 : -Dstraw="berry space" -Dblue="berry \"quotes\"" -Dblack="berry \\backslashes\\ "
59-
spark.colon.11:\
60-
-Dstraw="berry space" \
61-
-Dblue="berry \"quotes\"" \
62-
-Dblack="berry \\backslashes\\ " \
63-
-Dcherry=berry
64-
spark.colon.12:-Dstraw="berry space" -Dblue="berry \"quotes\"" \
65-
-Dblack="berry \\backslashes\\ " -Dcherry=berry
6645

bin/utils.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
function parse_java_property() {
2929
JAVA_PROPERTY_VALUE=$(\
3030
grep "^[[:space:]]*$1" "$PROPERTIES_FILE" | \
31+
head -n 1 | \
3132
sed "s/^[[:space:]]*$1//g" | \
3233
sed "s/^[[:space:]]*[:=]\{0,1\}//g" | \
3334
sed "s/^[[:space:]]*//g" | \

0 commit comments

Comments
 (0)