Skip to content

Commit b344bad

Browse files
committed
(Temporarily) re-enable “always coordinate” for testing purposes.
1 parent 0aec91e commit b344bad

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

core/src/main/scala/org/apache/spark/SparkHadoopWriter.scala

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,12 @@ class SparkHadoopWriter(@transient jobConf: JobConf)
131131
// attempts, which should only occur if speculation is enabled
132132
val speculationEnabled = sparkConf.getBoolean("spark.speculation", false)
133133
// This (undocumented) setting is an escape-hatch in case the commit code introduces bugs
134-
sparkConf.getBoolean("spark.hadoop.outputCommitCoordination.enabled", speculationEnabled)
134+
// sparkConf.getBoolean("spark.hadoop.outputCommitCoordination.enabled", speculationEnabled)
135+
136+
// TODO: revert this before merging the PR; this is enabled so this code path is exercised
137+
// by more tests (even though it might not be _necessary_, it should be _safe_ to do the
138+
// extra coordination)
139+
true
135140
}
136141
if (shouldCoordinateWithDriver) {
137142
val outputCommitCoordinator = SparkEnv.get.outputCommitCoordinator

0 commit comments

Comments
 (0)