activeIterator removed in MLUtils.saveAsLibSVMFile

Jakub Dubovsky · Jakub Dubovsky · commit 90a7d982e298 · 2014-12-30T14:00:23.000+01:00
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala b/mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala
@@ -154,10 +154,12 @@ object MLUtils {
   def saveAsLibSVMFile(data: RDD[LabeledPoint], dir: String) {
     // TODO: allow to specify label precision and feature precision.
     val dataStr = data.map { case LabeledPoint(label, features) =>
-      val featureStrings = features.toBreeze.activeIterator.map { case (i, v) =>
-        s"${i + 1}:$v"
+      val sb = new StringBuilder(label.toString)
+      features.foreachActive { case (i, v) =>
+        sb += ' '
+        sb ++= s"${i+1}:$v"
       }
-      (Iterator(label) ++ featureStrings).mkString(" ")
+      sb.mkString
     }
     dataStr.saveAsTextFile(dir)
   }

Original file line number	Diff line number	Diff line change
`@@ -154,10 +154,12 @@ object MLUtils {`
`154`	`154`	`def saveAsLibSVMFile(data: RDD[LabeledPoint], dir: String) {`
`155`	`155`	`// TODO: allow to specify label precision and feature precision.`
`156`	`156`	`val dataStr = data.map { case LabeledPoint(label, features) =>`
`157`		`- val featureStrings = features.toBreeze.activeIterator.map { case (i, v) =>`
`158`		`- s"${i + 1}:$v"`
	`157`	`+ val sb = new StringBuilder(label.toString)`
	`158`	`+ features.foreachActive { case (i, v) =>`
	`159`	`+ sb += ' '`
	`160`	`+ sb ++= s"${i+1}:$v"`
`159`	`161`	`}`
`160`		`- (Iterator(label) ++ featureStrings).mkString(" ")`
	`162`	`+ sb.mkString`
`161`	`163`	`}`
`162`	`164`	`dataStr.saveAsTextFile(dir)`
`163`	`165`	`}`