Skip to content

Commit 8110acf

Browse files
committed
Added scroll limit to Job timeline
1 parent 974a64a commit 8110acf

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

core/src/main/resources/org/apache/spark/ui/static/timeline-view.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ function drawApplicationTimeline(groupArray, eventObjArray, startTime) {
4545
});
4646
}
4747

48-
function drawJobTimeline(groupArray, eventObjArray) {
48+
function drawJobTimeline(groupArray, eventObjArray, startTime) {
4949
var groups = new vis.DataSet(groupArray);
5050
var items = new vis.DataSet(eventObjArray);
5151
var container = $('#job-timeline')[0];
@@ -55,6 +55,7 @@ function drawJobTimeline(groupArray, eventObjArray) {
5555
},
5656
editable: false,
5757
showCurrentTime: false,
58+
min: startTime,
5859
zoomable: false,
5960
};
6061

core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,11 @@ private[ui] class JobPage(parent: JobsTab) extends WebUIPage("job") {
138138
events.toSeq
139139
}
140140

141-
private def makeTimeline(stages: Seq[StageInfo], executors: Seq[ExecutorUIData]): Seq[Node] = {
141+
private def makeTimeline(
142+
stages: Seq[StageInfo],
143+
executors: Seq[ExecutorUIData],
144+
jobStartTime: Long): Seq[Node] = {
145+
142146
val stageEventJsonAsStrSeq = makeStageEvent(stages)
143147
val executorsJsonAsStrSeq = makeExecutorEvent(executors)
144148

@@ -167,7 +171,7 @@ private[ui] class JobPage(parent: JobsTab) extends WebUIPage("job") {
167171
</div> ++
168172
<div id="job-timeline"></div> ++
169173
<script type="text/javascript">
170-
{Unparsed(s"drawJobTimeline(${groupJsonArrayAsStr}, ${eventArrayAsStr});")}
174+
{Unparsed(s"drawJobTimeline(${groupJsonArrayAsStr}, ${eventArrayAsStr}, ${jobStartTime});")}
171175
</script>
172176
}
173177

@@ -297,8 +301,10 @@ private[ui] class JobPage(parent: JobsTab) extends WebUIPage("job") {
297301
</div>
298302

299303
var content = summary
304+
val jobStartTime = jobData.submissionTime.get
300305
content ++= <h4>Events on Job Timeline</h4> ++
301-
makeTimeline(activeStages ++ completedStages ++ failedStages, listener.executors)
306+
makeTimeline(activeStages ++ completedStages ++ failedStages,
307+
listener.executors, jobStartTime)
302308

303309
if (shouldShowActiveStages) {
304310
content ++= <h4 id="active">Active Stages ({activeStages.size})</h4> ++

0 commit comments

Comments
 (0)