Skip to content

Commit 6af181f

Browse files
committed
add TODOs
1 parent 8285134 commit 6af181f

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ class CrossValidator extends Estimator[CrossValidatorModel] with CrossValidatorP
122122
trainingDataset.unpersist()
123123
var i = 0
124124
while (i < numModels) {
125+
// TODO: duplicate evaluator to take extra params from input
125126
val metric = eval.evaluate(models(i).transform(validationDataset, epm(i)))
126127
logDebug(s"Got metric $metric for model trained with ${epm(i)}.")
127128
metrics(i) += metric

python/pyspark/ml/tuning.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ def fit(self, dataset, params={}):
224224
train = df.filter(~condition)
225225
for j in range(numModels):
226226
model = est.fit(train, epm[j])
227+
# TODO: duplicate evaluator to take extra params from input
227228
metric = eva.evaluate(model.transform(validation, epm[j]))
228229
metrics[j] += metric
229230
bestIndex = np.argmax(metrics)

0 commit comments

Comments
 (0)