Skip to content

Commit 55a28b9

Browse files
author
DB Tsai
committed
addressed feedback
1 parent 9acb9c9 commit 55a28b9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,8 @@ class LogisticRegression(override val uid: String)
229229
override def getThreshold: Double = super.getThreshold
230230

231231
/**
232-
* Whether to over-/undersamples each of training instance according to the given
233-
* weight in `weightCol`. If empty, all instances are supposed to have weights as 1.0.
232+
* Whether to over-/under-sample training instances according to the given weights in weightCol.
233+
* If empty, all instances are treated equally (weight 1.0).
234234
* Default is empty, so all instances have weight one.
235235
* @group setParam
236236
*/
@@ -598,6 +598,8 @@ private[classification] class MultiClassSummarizer extends Serializable {
598598

599599
/**
600600
* Abstraction for multinomial Logistic Regression Training results.
601+
* Currently, the training summary ignores the training weights except
602+
* for the objective trace.
601603
*/
602604
sealed trait LogisticRegressionTrainingSummary extends LogisticRegressionSummary {
603605

mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ class MultivariateOnlineSummarizer extends MultivariateStatisticalSummary with S
186186
}
187187

188188
/**
189-
* Sample unbiased estimation of variance of each dimension.
189+
* Unbiased estimate of sample variance of each dimension.
190190
*
191191
*/
192192
@Since("1.1.0")

0 commit comments

Comments
 (0)