Skip to content

Commit 530c8ad

Browse files
almogtavorsrowen
authored andcommitted
[SPARK-36273][SHUFFLE] Fix identical values comparison
This commit fixes the use of the "o.appAttemptId" variable instead of the mistaken "appAttemptId" variable. The current situation is a comparison of identical values. Jira issue report SPARK-36273. ### What changes were proposed in this pull request? This is a patch for SPARK-35546 which is needed for push-based shuffle. ### Why are the changes needed? A very minor fix of adding the reference from the other "FinalizeShuffleMerge". ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No unit tests were added. It's a pretty logical change. Closes #33493 from almogtavor/patch-1. Authored-by: Almog Tavor <[email protected]> Signed-off-by: Sean Owen <[email protected]>
1 parent fc29c91 commit 530c8ad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FinalizeShuffleMerge.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public boolean equals(Object other) {
6868
if (other != null && other instanceof FinalizeShuffleMerge) {
6969
FinalizeShuffleMerge o = (FinalizeShuffleMerge) other;
7070
return Objects.equal(appId, o.appId)
71-
&& appAttemptId == appAttemptId
71+
&& appAttemptId == o.appAttemptId
7272
&& shuffleId == o.shuffleId;
7373
}
7474
return false;

0 commit comments

Comments
 (0)