[SPARK-14391][LAUNCHER] Fix launcher communication test, take 2.

There's actually a race here: the state of the handler was changed before
the connection was set, so the test code could be notified of the state
change, wake up, and still see the connection as null, triggering the assert.

Author: Marcelo Vanzin <[email protected]>

Closes #12785 from vanzin/SPARK-14391.

(cherry picked from commit 73c20bf)

Author: Marcelo Vanzin

launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java

@@ -298,8 +298,8 @@ protected void handle(Message msg) throws IOException {
           Hello hello = (Hello) msg;
           ChildProcAppHandle handle = pending.remove(hello.secret);
           if (handle != null) {
-            handle.setState(SparkAppHandle.State.CONNECTED);
             handle.setConnection(this);
+            handle.setState(SparkAppHandle.State.CONNECTED);
             this.handle = handle;
           } else {
             throw new IllegalArgumentException("Received Hello for unknown client.");