Skip to content

Commit 05437e1

Browse files
author
Davies Liu
committed
address comment
1 parent 9b1b9ce commit 05437e1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ object DateTimeUtils {
3838

3939
// see http://stackoverflow.com/questions/466321/convert-unix-timestamp-to-julian
4040
// it's 2440587.5, rounding up to compatible with Hive
41-
final val JULIAN_DAY_OF_EPOCH = 2440588 //
41+
final val JULIAN_DAY_OF_EPOCH = 2440588
4242
final val SECONDS_PER_DAY = 60 * 60 * 24L
4343
final val MICROS_PER_SECOND = 1000L * 1000L
4444
final val NANOS_PER_SECOND = MICROS_PER_SECOND * 1000L

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,12 @@ class DateTimeUtilsSuite extends SparkFunSuite {
5252
assert(ns === 0)
5353
assert(fromJulianDay(d, ns) == 0L)
5454

55-
val t = new Timestamp(61394778610000L) // (2015, 6, 11, 10, 10, 10, 100)
55+
val t = Timestamp.valueOf("2015-06-11 10:10:10.100")
5656
val (d1, ns1) = toJulianDay(fromJavaTimestamp(t))
5757
val t1 = toJavaTimestamp(fromJulianDay(d1, ns1))
5858
assert(t.equals(t1))
5959

60-
val t2 = new Timestamp(61394814610000L) // (2015, 6, 11, 20, 10, 10, 100)
60+
val t2 = Timestamp.valueOf("2015-06-11 20:10:10.100")
6161
val (d2, ns2) = toJulianDay(fromJavaTimestamp(t2))
6262
val t22 = toJavaTimestamp(fromJulianDay(d2, ns2))
6363
assert(t2.equals(t22))

0 commit comments

Comments
 (0)