[SPARK-49590] Fix javaVersion to jdkVersion in E2E spark-versions test template
#119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @viirya can you please help to review ? |
dongjoon-hyun
changed the title
javaVersion to jdkVersion in E2E test template
dongjoon-hyun
changed the title
javaVersion to jdkVersion in E2E test templatejavaVersion to jdkVersion in E2E spark-versions test template
dongjoon-hyun
approved these changes
Sep 10, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
To @jiangzho , here are two recommendation for you.
- You had better refer code like the following at the exact line number which shows the code snippet directly.
- This is a general recommendation. Please use PR title as a place to show your goal of pull request instead of describing the problem. That's the main difference between PR title and JIRA title. For example, a good PR title would be about what to do and how to do instead of describing the problem like
E2E test template includes invalid spec field.
Member
|
cc @TQJADE , too. |
Member
|
Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR corrects an invalid spec in e2e test template -
javaVersion->jdkVersion.spark-kubernetes-operator/spark-operator-api/src/main/java/org/apache/spark/k8s/operator/spec/RuntimeVersions.java
Line 39 in bc422fd
Why are the changes needed?
The invalid test template causes e2e to fail e.g. https://github.com/apache/spark-kubernetes-operator/actions/runs/10745816799/job/29942467715?pr=118
Does this PR introduce any user-facing change?
No
How was this patch tested?
CIs
Was this patch authored or co-authored using generative AI tooling?
No