Skip to content

Conversation

@jiangzho
Copy link
Contributor

@jiangzho jiangzho commented Sep 6, 2024

What changes were proposed in this pull request?

This PR adds a module docs-utils to automatically generate config properties doc page from source.

Why are the changes needed?

This helps to keep config property docs up-to-date for properties by adding it as a gradle task.

Does this PR introduce any user-facing change?

No (doc only, not released)

How was this patch tested?

Pass the CIs

Was this patch authored or co-authored using generative AI tooling?

No

@jiangzho
Copy link
Contributor Author

jiangzho commented Sep 6, 2024

also cc @viirya

*/

ext {
javaMainClass = "org.apache.spark.k8s.operator.utils.ConfOptionDocGenerator"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2-space indentation please.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it technically impossible to put under build-tools as I suggested?

settings.gradle Outdated
include 'spark-submission-worker'
include 'spark-operator'
include 'docs-utils'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra line.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-49527] Generate Spark Operator Config Property Doc [SPARK-49527] Add ConfOptionDocGenerator to generate Spark Operator Config Property Doc Sep 6, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make CIs happy?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @jiangzho .
Pending CIs.

@dongjoon-hyun
Copy link
Member

It seems that spark-versions E2E test is still flaky although #119 is merged, @jiangzho and @TQJADE .

Screenshot 2024-09-11 at 07 59 44

@dongjoon-hyun
Copy link
Member

Let me re-trigger it.

@dongjoon-hyun
Copy link
Member

Merged to main.

jiangzho pushed a commit to jiangzho/spark-kubernetes-operator that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants