-
Notifications
You must be signed in to change notification settings - Fork 47
[SPARK-49527] Add ConfOptionDocGenerator to generate Spark Operator Config Property Doc
#118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
also cc @viirya |
| */ | ||
|
|
||
| ext { | ||
| javaMainClass = "org.apache.spark.k8s.operator.utils.ConfOptionDocGenerator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2-space indentation please.
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it technically impossible to put under build-tools as I suggested?
settings.gradle
Outdated
| include 'spark-submission-worker' | ||
| include 'spark-operator' | ||
| include 'docs-utils' | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove extra line.
ConfOptionDocGenerator to generate Spark Operator Config Property Doc
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make CIs happy?
Let's not add docs in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @jiangzho .
Pending CIs.
|
Let me re-trigger it. |
|
Merged to main. |

What changes were proposed in this pull request?
This PR adds a module
docs-utilsto automatically generate config properties doc page from source.Why are the changes needed?
This helps to keep config property docs up-to-date for properties by adding it as a gradle task.
Does this PR introduce any user-facing change?
No (doc only, not released)
How was this patch tested?
Pass the CIs
Was this patch authored or co-authored using generative AI tooling?
No