Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Lack of support for Swole asynchronous style #12811

Closed
2 of 3 tasks
wisonlau opened this issue Nov 29, 2024 · 1 comment
Closed
2 of 3 tasks

[Bug] Lack of support for Swole asynchronous style #12811

wisonlau opened this issue Nov 29, 2024 · 1 comment
Labels
bug Something isn't working and you are sure it's a bug!

Comments

@wisonlau
Copy link

wisonlau commented Nov 29, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Apache SkyWalking Component

PHP (apache/skywalking-php)

What happened

#12806
This fix only supports coroutine style and lacks asynchronous style. Currently, I am using asynchronous style
https://wiki.swoole.com/zh-cn/#/http_server
image

What you expected to happen

Hope to support asynchronous style

How to reproduce

hyperf frame catalogue: config/server.php

'mode' => SWOOLE_BASE,
'servers' => [
        [
            'name' => 'http',
            'type' => ServerInterface::SERVER_HTTP,
            'host' => env('HTTP_HOST', '0.0.0.0'),
            'port' => (int) env('HTTP_POER', 9501),
            'sock_type' => SWOOLE_SOCK_TCP,
            'callbacks' => [
                Event::ON_REQUEST => [Hyperf\HttpServer\Server::class, 'onRequest'],
            ],
        ],
]

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@wisonlau wisonlau added the bug Something isn't working and you are sure it's a bug! label Nov 29, 2024
@wisonlau wisonlau changed the title [Bug] [Bug] Lack of support for Swole asynchronous style Nov 29, 2024
@wisonlau
Copy link
Author

@jmjoy have a look

@apache apache locked and limited conversation to collaborators Nov 29, 2024
@wu-sheng wu-sheng converted this issue into discussion #12812 Nov 29, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working and you are sure it's a bug!
Projects
None yet
Development

No branches or pull requests

1 participant