Skip to content

[Improve][Docs] Refactor MySQL-CDC docs#5302

Merged
TyrantLucifer merged 4 commits into
apache:devfrom
hailin0:dev-reformat-mysql-cdc-docs
Aug 31, 2023
Merged

[Improve][Docs] Refactor MySQL-CDC docs#5302
TyrantLucifer merged 4 commits into
apache:devfrom
hailin0:dev-reformat-mysql-cdc-docs

Conversation

@hailin0
Copy link
Copy Markdown
Member

@hailin0 hailin0 commented Aug 14, 2023

Purpose of this pull request

Check list

@hailin0 hailin0 force-pushed the dev-reformat-mysql-cdc-docs branch from 8eaa8f1 to 586f3e4 Compare August 14, 2023 10:56
StopMode.SPECIFIC,
SourceOptions.STOP_SPECIFIC_OFFSET_FILE,
SourceOptions.STOP_SPECIFIC_OFFSET_POS)
.conditional(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unsupport options

return BasicType.BOOLEAN_TYPE;
case MYSQL_TINYINT:
return column.length() == 1 ? BasicType.BOOLEAN_TYPE : BasicType.INT_TYPE;
return BasicType.BYTE_TYPE;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unsupported convert

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It came from #5105 , any reason we should remove this? cc @Carl-Zhou-CN

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The read data is not converted according to this mapping...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hisoka-X fixed

@hailin0
Copy link
Copy Markdown
Member Author

hailin0 commented Aug 14, 2023

@EricJoy2048 PTAL

@hailin0 hailin0 force-pushed the dev-reformat-mysql-cdc-docs branch from 586f3e4 to 4568268 Compare August 14, 2023 14:05
@hailin0 hailin0 added this to the 2.3.4 milestone Aug 23, 2023
@TyrantLucifer TyrantLucifer merged commit 74530a0 into apache:dev Aug 31, 2023
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
* [Improve][Docs] Refactor MySQL-CDC docs

* Update MySqlTypeUtils.java

* Update MySQL-CDC.md
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
* [Improve][Docs] Refactor MySQL-CDC docs

* Update MySqlTypeUtils.java

* Update MySQL-CDC.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants