-
Notifications
You must be signed in to change notification settings - Fork 12k
Let name server generate valid JSON response when process topic route queries #4432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4432 +/- ##
=============================================
- Coverage 48.14% 48.05% -0.10%
+ Complexity 5108 5092 -16
=============================================
Files 646 646
Lines 42909 42911 +2
Branches 5611 5611
=============================================
- Hits 20658 20620 -38
- Misses 19743 19774 +31
- Partials 2508 2517 +9
Continue to review full report at Codecov.
|
| import java.io.UnsupportedEncodingException; | ||
| import java.util.Properties; | ||
| import java.util.concurrent.atomic.AtomicLong; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should adjust the import order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks feature 'optimize-import-on-fly' of Idea is not perfect. Reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… queries (apache#4432) * Let name server generate valid JSON response when process topic route queries
What is the purpose of the change
As per title
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.