Skip to content

Conversation

@lizhanhui
Copy link
Contributor

What is the purpose of the change

As per title

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Jun 8, 2022

Coverage Status

Coverage increased (+0.03%) to 52.064% when pulling 4d112dc on lizhanhui:apache_develop into aacaf91 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #4432 (d01b04f) into develop (aacaf91) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4432      +/-   ##
=============================================
- Coverage      48.14%   48.05%   -0.10%     
+ Complexity      5108     5092      -16     
=============================================
  Files            646      646              
  Lines          42909    42911       +2     
  Branches        5611     5611              
=============================================
- Hits           20658    20620      -38     
- Misses         19743    19774      +31     
- Partials        2508     2517       +9     
Impacted Files Coverage Δ
...tmq/namesrv/processor/DefaultRequestProcessor.java 73.58% <100.00%> (ø)
...cketmq/remoting/protocol/RemotingSerializable.java 77.77% <100.00%> (+15.27%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...va/org/apache/rocketmq/logging/inner/Appender.java 29.21% <0.00%> (-7.87%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-5.98%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 40.84% <0.00%> (-3.00%) ⬇️
...ketmq/common/protocol/body/RegisterBrokerBody.java 84.78% <0.00%> (-1.09%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aacaf91...d01b04f. Read the comment docs.

import java.io.UnsupportedEncodingException;
import java.util.Properties;
import java.util.concurrent.atomic.AtomicLong;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should adjust the import order

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks feature 'optimize-import-on-fly' of Idea is not perfect. Reverted.

Copy link
Member

@hzh0425 hzh0425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhanhui lizhanhui merged commit 73b9ac8 into apache:develop Jun 9, 2022
@lizhanhui lizhanhui deleted the apache_develop branch June 9, 2022 01:53
@duhenglucky duhenglucky added this to the 4.9.4 milestone Jun 9, 2022
yuz10 added a commit that referenced this pull request Jun 17, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
… queries (apache#4432)

* Let name server generate valid JSON response when process topic route queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants