Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] DLedger doesn't support LMQ #8927

Open
3 tasks done
bxfjb opened this issue Nov 14, 2024 · 1 comment · May be fixed by #8928
Open
3 tasks done

[Bug] DLedger doesn't support LMQ #8927

bxfjb opened this issue Nov 14, 2024 · 1 comment · May be fixed by #8928

Comments

@bxfjb
Copy link
Contributor

bxfjb commented Nov 14, 2024

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

any

RocketMQ version

develop

JDK Version

any

Describe the Bug

Lmq msg's queueOffset field is set to 0 wrongly. Easy to reproduce. Actually I found following codes in MessageExtEncoder.java:
image
But the latter update of queueOffset was not found.

Steps to Reproduce

Run a broker under latest develop version.
Send msgs and set Lmq related properties.
The queueOffset of these msgs is zero.

What Did You Expect to See?

Correct queueOffset.

What Did You See Instead?

Zero queueOffset.

Additional Context

No response
@bxfjb bxfjb linked a pull request Nov 15, 2024 that will close this issue
Open
@bxfjb
Copy link
Contributor Author

bxfjb commented Nov 15, 2024

I found the update code in CommitLog.java
9ead6580-b904-4d8b-9904-ba640b3d8948
But it seems that DLedgerCommitLog doesn't support LMQ for now, I'll change this issue's title and commit another pr later.

@bxfjb bxfjb changed the title [Bug] Lmq msg queueOffset is set to 0 wrongly [Bug] DLedger doesn't support LMQ Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8927] DLedger support LMQ bxfjb/rocketmq
1 participant
@bxfjb