Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RIP-46] Add logging metrics exporter #5678

Closed
ShadowySpirits opened this issue Dec 10, 2022 · 7 comments
Closed

[RIP-46] Add logging metrics exporter #5678

ShadowySpirits opened this issue Dec 10, 2022 · 7 comments
Assignees
Labels

Comments

@ShadowySpirits
Copy link
Member

For now, we need an Opentelemetry collector or Prometheus to explore metrics. It's useful to add logging exporter for debugging purposes.

@drpmma drpmma added the Good First Issue Good First Issue label Dec 13, 2022
@Bughue
Copy link

Bughue commented Dec 19, 2022

I would like to give it a try, can you assign this issue to me

@Bughue
Copy link

Bughue commented Jan 3, 2023

For now, we need an Opentelemetry collector or Prometheus to explore metrics. It's useful to add logging exporter for debugging purposes.

I found that there is already a rocketmq-exporter(https://github.com/apache/rocketmq-exporter), what's the difference?
Do they have different purposes?

@ShadowySpirits
Copy link
Member Author

For now, we need an Opentelemetry collector or Prometheus to explore metrics. It's useful to add logging exporter for debugging purposes.

I found that there is already a rocketmq-exporter(https://github.com/apache/rocketmq-exporter), what's the difference? Do they have different purposes?

This wiki Observability Improvement for RocketMQ can answer your questions.

@Bughue
Copy link

Bughue commented Jan 6, 2023

Observability Improvement for RocketMQ

Got it~Does this issue include all of the following tasks? Where should I start

We split this proposal into several tasks:
Task1: Define the specification of metric.
Task2: Implement metrics collector and exporter framework in broker and proxy.
Task3: Develop metrics for broker and proxy.
Task4: Backport new metrics to rocketmq-exporter.
Task5: Other ecosystem work, like document, Grafana dashboard template, etc.

@ShadowySpirits
Copy link
Member Author

No, this issue aims to add a log exporter. Currently, we have otlp exporter and Prometheus exporter.

public enum MetricsExporterType {
DISABLE(0),
OTLP_GRPC(1),
PROM(2);

@Bughue
Copy link

Bughue commented Jan 6, 2023

No, this issue aims to add a log exporter. Currently, we have otlp exporter and Prometheus exporter.

public enum MetricsExporterType {
DISABLE(0),
OTLP_GRPC(1),
PROM(2);

ok~thx

@ShadowySpirits
Copy link
Member Author

Closed as completed via #6234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants