[improve][ws] Add memory limit configuration for Pulsar client used in Websocket proxy #22666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Websocket proxy
merlimat
approved these changes
May 7, 2024
|
nit: can we add comments in the config files and *ServiceConfiguration that it is disabled, by default? |
heesung-sn
approved these changes
May 7, 2024
Technoboy-
pushed a commit
that referenced
this pull request
May 8, 2024
…n Websocket proxy (#22666)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2024
…n Websocket proxy (apache#22666) (cherry picked from commit 80d4675) (cherry picked from commit e5515c5)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…n Websocket proxy (apache#22666) (cherry picked from commit 80d4675) (cherry picked from commit e5515c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's no explicit flow control in the Websocket proxy for producers. If too many messages are pushed, the proxy (or broker, if ws proxy runs with the broker) will run out of memory.
Modifications
add
webSocketPulsarClientMemoryLimitInMBconfiguration option to limit the memory.by default, it is unlimited. Can be set to a value such as
64to keep the direct memory used by the Pulsar client under 64 MB.Documentation
docdoc-requireddoc-not-neededdoc-complete