Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][client][branch-2.11]PIP-189: No batching if only one message in batch #18548

Merged
merged 1 commit into from
Nov 21, 2022
Merged

[improve][client][branch-2.11]PIP-189: No batching if only one message in batch #18548

merged 1 commit into from
Nov 21, 2022

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Nov 20, 2022

Motivation

Cherry-pick #16605

Modifications

Cherry-pick #16605

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@AnonHxy
[improve][client]PIP-189: No batching if only one message in batch (a…
0c3d37d 
…pache#16605)

[improve][client]PIP-189: No batching if only one message in batch apache#16605

### Motivation

* See apache#16619

### Modifications

* See apache#16619
* Most of the Modifications are relevant to `BatchMessageContainerImpl`
* Of course there are some tests about batching need to be modified, because batched producer can also pubulish non-batched messages when this PIP applies. The tests include:
    * `RGUsageMTAggrWaitForAllMsgsTest`
    * `BatchMessageTest`
    * `BrokerEntryMetadataE2ETest`
    * `ClientDeduplicationTest`
    * `TopicReaderTest`
    * `PulsarClientToolTest`
@AnonHxy AnonHxy self-assigned this Nov 20, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 20, 2022
@AnonHxy AnonHxy added ready-to-test and removed doc-not-needed Your PR changes do not impact docs labels Nov 20, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 20, 2022
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Nov 20, 2022

@Technoboy- @Jason918 PTAL

@Jason918 Jason918 requested a review from eolivelli November 21, 2022 03:03
Jason918
Jason918 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jason918 Jason918 changed the title [cherry-pick][branch-2.11] PIP-189: No batching if only one message in batch (#… [improve][client][branch-2.11]PIP-189: No batching if only one message in batch Nov 21, 2022
@Jason918 Jason918 mentioned this pull request Nov 21, 2022
Merged
5 tasks
eolivelli
eolivelli approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit 7080120 into apache:branch-2.11 Nov 21, 2022
@eolivelli
Copy link
Contributor

thank you @Jason918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason918 Jason918 Jason918 approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

@AnonHxy AnonHxy

Labels
doc-not-needed Your PR changes do not impact docs ready-to-test release/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnonHxy @eolivelli @Jason918 @Technoboy-