Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread.sleep used in some unit tests; consider replacing with Awaitility #23

Open
dlg99 opened this issue Jun 21, 2021 · 1 comment
Open

Thread.sleep used in some unit tests; consider replacing with Awaitility #23

dlg99 opened this issue Jun 21, 2021 · 1 comment

Comments

@dlg99
Copy link
Contributor

dlg99 commented Jun 21, 2021

Thread.sleep used in some unit tests (search code for it); consider replacing with Awaitility.

This is a follow up on #22 (comment)

Priority is fairly low IMO - occurences of this are very limited, test run reasonably fast AFAICT, it's unclear what specifically the tests have to wait for etc.
@mattisonchao
Copy link
Member

I will fix it @dlg99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlg99 @mattisonchao