Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update h2spec #262

Closed
lomigmegard opened this issue Jul 23, 2023 · 4 comments · Fixed by #266
Closed

Update h2spec #262

lomigmegard opened this issue Jul 23, 2023 · 4 comments · Fixed by #266
Milestone

Comments

@lomigmegard
Copy link
Contributor

Currently tests are using version 1.5.0, which is from 2016.

My current machine (Apple M1) Seg Fault on it (see #218 (comment)), making the H2SpecIntegrationSpec test suite fail.

./http2-tests/target/h2spec_darwin_amd64/h2spec --dryrun
[1]    3328 segmentation fault  ./http2-tests/target/h2spec_darwin_amd64/h2spec --dryrun

Updating h2spec to its latest version 2.6.0 would hopefully fix the issue.

Note this is non-critical as the current version is working well in the CI environment.

@pjfanning
Copy link
Contributor

I'm not sure if h2spec supports Mac Silicon.

There only appear to be downloads for Mac AMD64 - https://github.com/summerwind/h2spec/releases/

@lomigmegard
Copy link
Contributor Author

Indeed, no binaries for arm64/aarch64.

I still think this issue makes sense to eventually update to a more recent version.

@lomigmegard
Copy link
Contributor Author

The update to 2.6.0 makes the new h2spec binary work on Apple Silicon, at least transparently using Rosetta (#218 (comment))

@pjfanning pjfanning added this to the 1.0.0 milestone Jul 24, 2023
@jrudolph
Copy link
Contributor

The update to 2.6.0 makes the new h2spec binary work on Apple Silicon, at least transparently using Rosetta (#218 (comment))

Great to know. I guess Rosetta hit a corner case in the old release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants