Skip to content

Commit bde66d9

Browse files
committed
PARQUET-1503: Remove Ints Utility Class
1 parent e7835e0 commit bde66d9

File tree

7 files changed

+11
-61
lines changed

7 files changed

+11
-61
lines changed

parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterV2.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import java.io.IOException;
2222

23-
import org.apache.parquet.Ints;
2423
import org.apache.parquet.bytes.BytesInput;
2524
import org.apache.parquet.column.ColumnDescriptor;
2625
import org.apache.parquet.column.Encoding;
@@ -78,7 +77,7 @@ void writePage(int rowCount, int valueCount, Statistics<?> statistics, ValuesWri
7877
Encoding encoding = values.getEncoding();
7978
pageWriter.writePageV2(
8079
rowCount,
81-
Ints.checkedCast(statistics.getNumNulls()),
80+
Math.toIntExact(statistics.getNumNulls()),
8281
valueCount,
8382
repetitionLevels.getBytes(),
8483
definitionLevels.getBytes(),

parquet-column/src/main/java/org/apache/parquet/column/page/DataPageV1.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import java.util.Optional;
2222

23-
import org.apache.parquet.Ints;
2423
import org.apache.parquet.bytes.BytesInput;
2524
import org.apache.parquet.column.Encoding;
2625
import org.apache.parquet.column.statistics.Statistics;
@@ -44,7 +43,7 @@ public class DataPageV1 extends DataPage {
4443
* @param valuesEncoding the values encoding for this page
4544
*/
4645
public DataPageV1(BytesInput bytes, int valueCount, int uncompressedSize, Statistics<?> statistics, Encoding rlEncoding, Encoding dlEncoding, Encoding valuesEncoding) {
47-
super(Ints.checkedCast(bytes.size()), uncompressedSize, valueCount);
46+
super(Math.toIntExact(bytes.size()), uncompressedSize, valueCount);
4847
this.bytes = bytes;
4948
this.statistics = statistics;
5049
this.rlEncoding = rlEncoding;
@@ -66,7 +65,7 @@ public DataPageV1(BytesInput bytes, int valueCount, int uncompressedSize, Statis
6665
*/
6766
public DataPageV1(BytesInput bytes, int valueCount, int uncompressedSize, long firstRowIndex, int rowCount,
6867
Statistics<?> statistics, Encoding rlEncoding, Encoding dlEncoding, Encoding valuesEncoding) {
69-
super(Ints.checkedCast(bytes.size()), uncompressedSize, valueCount, firstRowIndex);
68+
super(Math.toIntExact(bytes.size()), uncompressedSize, valueCount, firstRowIndex);
7069
this.bytes = bytes;
7170
this.statistics = statistics;
7271
this.rlEncoding = rlEncoding;

parquet-column/src/main/java/org/apache/parquet/column/page/DataPageV2.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import java.util.Optional;
2222

23-
import org.apache.parquet.Ints;
2423
import org.apache.parquet.bytes.BytesInput;
2524
import org.apache.parquet.column.Encoding;
2625
import org.apache.parquet.column.statistics.Statistics;
@@ -47,7 +46,7 @@ public static DataPageV2 uncompressed(
4746
rowCount, nullCount, valueCount,
4847
repetitionLevels, definitionLevels,
4948
dataEncoding, data,
50-
Ints.checkedCast(repetitionLevels.size() + definitionLevels.size() + data.size()),
49+
Math.toIntExact(repetitionLevels.size() + definitionLevels.size() + data.size()),
5150
statistics,
5251
false);
5352
}
@@ -73,7 +72,7 @@ public static DataPageV2 uncompressed(
7372
rowCount, nullCount, valueCount, firstRowIndex,
7473
repetitionLevels, definitionLevels,
7574
dataEncoding, data,
76-
Ints.checkedCast(repetitionLevels.size() + definitionLevels.size() + data.size()),
75+
Math.toIntExact(repetitionLevels.size() + definitionLevels.size() + data.size()),
7776
statistics,
7877
false);
7978
}
@@ -121,7 +120,7 @@ public DataPageV2(
121120
int uncompressedSize,
122121
Statistics<?> statistics,
123122
boolean isCompressed) {
124-
super(Ints.checkedCast(repetitionLevels.size() + definitionLevels.size() + data.size()), uncompressedSize, valueCount);
123+
super(Math.toIntExact(repetitionLevels.size() + definitionLevels.size() + data.size()), uncompressedSize, valueCount);
125124
this.rowCount = rowCount;
126125
this.nullCount = nullCount;
127126
this.repetitionLevels = repetitionLevels;
@@ -139,7 +138,7 @@ private DataPageV2(
139138
int uncompressedSize,
140139
Statistics<?> statistics,
141140
boolean isCompressed) {
142-
super(Ints.checkedCast(repetitionLevels.size() + definitionLevels.size() + data.size()), uncompressedSize,
141+
super(Math.toIntExact(repetitionLevels.size() + definitionLevels.size() + data.size()), uncompressedSize,
143142
valueCount, firstRowIndex);
144143
this.rowCount = rowCount;
145144
this.nullCount = nullCount;

parquet-column/src/main/java/org/apache/parquet/column/page/DictionaryPage.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
import java.io.IOException;
2424

25-
import org.apache.parquet.Ints;
2625
import org.apache.parquet.bytes.BytesInput;
2726
import org.apache.parquet.column.Encoding;
2827

@@ -53,7 +52,7 @@ public DictionaryPage(BytesInput bytes, int dictionarySize, Encoding encoding) {
5352
* @param encoding the encoding used
5453
*/
5554
public DictionaryPage(BytesInput bytes, int uncompressedSize, int dictionarySize, Encoding encoding) {
56-
super(Ints.checkedCast(bytes.size()), uncompressedSize);
55+
super(Math.toIntExact(bytes.size()), uncompressedSize);
5756
this.bytes = checkNotNull(bytes, "bytes");
5857
this.dictionarySize = dictionarySize;
5958
this.encoding = checkNotNull(encoding, "encoding");

parquet-column/src/main/java/org/apache/parquet/column/values/rle/RunLengthBitPackingHybridValuesWriter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import java.util.Objects;
2323

2424
import org.apache.parquet.bytes.ByteBufferAllocator;
25-
import org.apache.parquet.Ints;
2625
import org.apache.parquet.bytes.BytesInput;
2726
import org.apache.parquet.column.Encoding;
2827
import org.apache.parquet.column.values.ValuesWriter;
@@ -68,7 +67,7 @@ public BytesInput getBytes() {
6867
try {
6968
// prepend the length of the column
7069
BytesInput rle = encoder.toBytes();
71-
return BytesInput.concat(BytesInput.fromInt(Ints.checkedCast(rle.size())), rle);
70+
return BytesInput.concat(BytesInput.fromInt(Math.toIntExact(rle.size())), rle);
7271
} catch (IOException e) {
7372
throw new ParquetEncodingException(e);
7473
}

parquet-common/src/main/java/org/apache/parquet/Ints.java

Lines changed: 0 additions & 42 deletions
This file was deleted.

parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,13 @@
1818
*/
1919
package org.apache.parquet.hadoop;
2020

21-
import static org.apache.parquet.Ints.checkedCast;
22-
2321
import java.io.IOException;
2422
import java.util.HashMap;
2523
import java.util.LinkedList;
2624
import java.util.List;
2725
import java.util.Map;
2826
import java.util.Optional;
2927
import java.util.PrimitiveIterator;
30-
import org.apache.parquet.Ints;
3128
import org.apache.parquet.bytes.BytesInput;
3229
import org.apache.parquet.column.ColumnDescriptor;
3330
import org.apache.parquet.column.page.DataPage;
@@ -118,7 +115,7 @@ public DataPage visit(DataPageV1 dataPageV1) {
118115
dataPageV1.getValueCount(),
119116
dataPageV1.getUncompressedSize(),
120117
firstRowIndex,
121-
checkedCast(offsetIndex.getLastRowIndex(currentPageIndex, rowCount) - firstRowIndex + 1),
118+
Math.toIntExact(offsetIndex.getLastRowIndex(currentPageIndex, rowCount) - firstRowIndex + 1),
122119
dataPageV1.getStatistics(),
123120
dataPageV1.getRlEncoding(),
124121
dataPageV1.getDlEncoding(),
@@ -148,7 +145,7 @@ public DataPage visit(DataPageV2 dataPageV2) {
148145
}
149146
}
150147
try {
151-
int uncompressedSize = Ints.checkedCast(
148+
int uncompressedSize = Math.toIntExact(
152149
dataPageV2.getUncompressedSize()
153150
- dataPageV2.getDefinitionLevels().size()
154151
- dataPageV2.getRepetitionLevels().size());

0 commit comments

Comments
 (0)