You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I've reviewed the format change it was obvious to me to use the "2-byte IEEE little-endian format". Now, I've faced another approach to encode 2 byte FP numbers: bfloat16. Since neither java nor c++ support 2 byte FP numbers natively we probably need to convert the encoded numbers to float. For bfloat16 it would be more performant to do so.
It might worth adding bfloat16 to the format as well and add implementations for it in the same round. WDYT?
I would support a proposal for implementing bfloat16, maybe even as a canonical extension type in Arrow.
However, I have a hesitency to including that in this round of implementations. I think it should be considered seperately.
My understanding is that the implementations have already begun (I messaged the parties working on the implementations, to create appropriate tickets).
It would prolong the format review and implementations.
Part of that prolonging is that I forsee additional back-and-forth over debating why "bfloat16"; why not tensorfloat? Why not add both?
And my experience has been that these conversations take a really long time for the Parquet community. It could easily add months to this process.
Float16 being an IEEE standard has a simplicity to its inclusion.
So, I guess my takeaway is that I support us opening a seperate format PR for bfloat16 inclusion, and having that occur seperate from the work of including, and implementing, IEEE float16.
I've mentioned bfloat16 only because of the ease of converting back and forth to java/c++ float which we will probably need to be implemented for IEEE Float16 as well. But I agree, we should not block the format release because of additional discussions about this additional topic.
Reporter: Julien Le Dem / @julienledem
Assignee: Anja Boskovic / @anjakefala
Related issues:
PRs and other links:
Note: This issue was originally created as PARQUET-758. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: