From 451cbc6ff8cdde8c94816012e7f86ea9ed17e706 Mon Sep 17 00:00:00 2001 From: ashishk Date: Tue, 22 Jul 2025 15:55:18 +0530 Subject: [PATCH] HDDS-13489. Fix SCMBlockdeleting unnecessary iteration in corner case. --- .../apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java index 3d4509b9d87f..0ad4bdabbfa6 100644 --- a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java +++ b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java @@ -451,11 +451,11 @@ public DatanodeDeletedBlockTransactions getTransactions( Set replicas = containerManager .getContainerReplicas( ContainerID.valueOf(txn.getContainerID())); - if (checkInadequateReplica(replicas, txn, dnList)) { + if (!checkInadequateReplica(replicas, txn, dnList)) { + getTransaction(txn, transactions, replicas, commandStatus); + } else { metrics.incrSkippedTransaction(); - continue; } - getTransaction(txn, transactions, replicas, commandStatus); } else if (txn.getCount() >= maxRetry || containerManager.getContainer(id).isOpen()) { metrics.incrSkippedTransaction(); }