From 506092965bb3c005c3258f7f2d058d07f00ab950 Mon Sep 17 00:00:00 2001 From: Sreeja Chintalapati Date: Mon, 7 Jul 2025 12:24:26 +0530 Subject: [PATCH 1/2] HDDS-13387. OMSnapshotCreateRequest logs invalid warning about DefaultReplicationConfig --- .../ozone/om/request/snapshot/OMSnapshotCreateRequest.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java index 66051851a2e6..92f3f6d9478e 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java @@ -341,12 +341,8 @@ private long estimateBucketDataSize(OmBucketInfo bucketInfo) { if (defRC == null) { // Note: A lot of tests are not setting bucket DefaultReplicationConfig, // sometimes intentionally. - // Fall back to config default and print warning level log. + // Fall back to config default. rc = ReplicationConfig.getDefault(new OzoneConfiguration()); - LOG.warn("DefaultReplicationConfig is not correctly set in " + - "OmBucketInfo for volume '{}' bucket '{}'. " + - "Falling back to config default '{}'", - bucketInfo.getVolumeName(), bucketInfo.getBucketName(), rc); } else { rc = defRC.getReplicationConfig(); } From f3cbd7f08e99c4f74a3c35b51c354d49b508d529 Mon Sep 17 00:00:00 2001 From: Sreeja Chintalapati Date: Mon, 14 Jul 2025 09:50:29 +0530 Subject: [PATCH 2/2] Removed misleading comments --- .../ozone/om/request/snapshot/OMSnapshotCreateRequest.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java index 92f3f6d9478e..ea21b3122681 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java @@ -339,8 +339,6 @@ private long estimateBucketDataSize(OmBucketInfo bucketInfo) { DefaultReplicationConfig defRC = bucketInfo.getDefaultReplicationConfig(); final ReplicationConfig rc; if (defRC == null) { - // Note: A lot of tests are not setting bucket DefaultReplicationConfig, - // sometimes intentionally. // Fall back to config default. rc = ReplicationConfig.getDefault(new OzoneConfiguration()); } else {