diff --git a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java index 5e41f5a854e7..c6f9e1c7cf1b 100644 --- a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java +++ b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java @@ -98,7 +98,6 @@ public final class DBStoreBuilder { private RocksDBConfiguration rocksDBConfiguration; // Flag to indicate if the RocksDB should be opened readonly. private boolean openReadOnly = false; - private int maxFSSnapshots = 0; private final DBProfile defaultCfProfile; private boolean enableCompactionDag; private boolean createCheckpointDirs = true; @@ -230,18 +229,14 @@ public DBStore build() throws IOException { } return new RDBStore(dbFile, rocksDBOption, statistics, writeOptions, tableConfigs, - registry.build(), openReadOnly, maxFSSnapshots, dbJmxBeanNameName, - enableCompactionDag, maxDbUpdatesSizeThreshold, createCheckpointDirs, - configuration, enableRocksDbMetrics); + registry.build(), openReadOnly, dbJmxBeanNameName, enableCompactionDag, + maxDbUpdatesSizeThreshold, createCheckpointDirs, configuration, + enableRocksDbMetrics); } finally { tableConfigs.forEach(TableConfig::close); } } - public DBStoreBuilder setMaxFSSnapshots(int maxFSSnapshots) { - this.maxFSSnapshots = maxFSSnapshots; - return this; - } public DBStoreBuilder setName(String name) { dbname = name; return this; diff --git a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java index e3ecaca6386a..b44c2685caee 100644 --- a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java +++ b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java @@ -78,7 +78,7 @@ public class RDBStore implements DBStore { @SuppressWarnings("parameternumber") public RDBStore(File dbFile, ManagedDBOptions dbOptions, ManagedStatistics statistics, ManagedWriteOptions writeOptions, Set families, - CodecRegistry registry, boolean readOnly, int maxFSSnapshots, + CodecRegistry registry, boolean readOnly, String dbJmxBeanName, boolean enableCompactionDag, long maxDbUpdatesSizeThreshold, boolean createCheckpointDirs, diff --git a/hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBStore.java b/hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBStore.java index 81626f935754..a2f91d5b2e1e 100644 --- a/hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBStore.java +++ b/hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBStore.java @@ -61,7 +61,7 @@ public static RDBStore newRDBStore(File dbFile, ManagedDBOptions options, long maxDbUpdatesSizeThreshold) throws IOException { return new RDBStore(dbFile, options, null, new ManagedWriteOptions(), families, - CodecRegistry.newBuilder().build(), false, 1000, null, false, + CodecRegistry.newBuilder().build(), false, null, false, maxDbUpdatesSizeThreshold, true, null, true); } diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java index 240c26fa14b0..86a9dda47564 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java @@ -23,8 +23,6 @@ import static org.apache.hadoop.ozone.OzoneConsts.OM_SNAPSHOT_CHECKPOINT_DIR; import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_DB_MAX_OPEN_FILES; import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_DB_MAX_OPEN_FILES_DEFAULT; -import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_FS_SNAPSHOT_MAX_LIMIT; -import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_FS_SNAPSHOT_MAX_LIMIT_DEFAULT; import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES; import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES_DEFAULT; import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_SNAPSHOT_ROCKSDB_METRICS_ENABLED; @@ -589,15 +587,12 @@ public static DBStore loadDB(OzoneConfiguration configuration, File metaDir, boolean createCheckpointDirs, boolean enableRocksDBMetrics) throws IOException { - final int maxFSSnapshots = configuration.getInt( - OZONE_OM_FS_SNAPSHOT_MAX_LIMIT, OZONE_OM_FS_SNAPSHOT_MAX_LIMIT_DEFAULT); RocksDBConfiguration rocksDBConfiguration = configuration.getObject(RocksDBConfiguration.class); DBStoreBuilder dbStoreBuilder = DBStoreBuilder.newBuilder(configuration, rocksDBConfiguration).setName(dbName) .setOpenReadOnly(readOnly) .setPath(Paths.get(metaDir.getPath())) - .setMaxFSSnapshots(maxFSSnapshots) .setEnableCompactionDag(enableCompactionDag) .setCreateCheckpointDirs(createCheckpointDirs) .setMaxNumberOfOpenFiles(maxOpenFiles)