diff --git a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithAllRunning.java b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithAllRunning.java index 49bc7e0a3c96..87faa575077c 100644 --- a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithAllRunning.java +++ b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithAllRunning.java @@ -378,7 +378,7 @@ public void testFailoverWithSuggestedLeader() throws Exception { } } assertNotNull(followerOM); - assertSame(followerOM.getOmRatisServer().checkLeaderStatus(), + assertSame(followerOM.getOmRatisServer().getLeaderStatus(), OzoneManagerRatisServer.RaftServerStatus.NOT_LEADER); OzoneManagerProtocolProtos.OMRequest writeRequest = diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java index eb5d83b5a8ab..2789ed5a2489 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java @@ -3051,7 +3051,7 @@ public List> getRatisRoles() { if (null == omRatisServer) { return getRatisRolesException("Server is shutting down"); } - String leaderReadiness = omRatisServer.checkLeaderStatus().name(); + String leaderReadiness = omRatisServer.getLeaderStatus().name(); final RaftPeerId leaderId = omRatisServer.getLeaderId(); if (leaderId == null) { LOG.error(NO_LEADER_ERROR_MESSAGE); @@ -4214,7 +4214,7 @@ public long getMaxUserVolumeCount() { */ public boolean isLeaderReady() { final OzoneManagerRatisServer ratisServer = omRatisServer; - return ratisServer != null && ratisServer.checkLeaderStatus() == LEADER_AND_READY; + return ratisServer != null && ratisServer.getLeaderStatus() == LEADER_AND_READY; } /** @@ -4225,7 +4225,7 @@ public boolean isLeaderReady() { public void checkLeaderStatus() throws OMNotLeaderException, OMLeaderNotReadyException { OzoneManagerRatisServer.RaftServerStatus raftServerStatus = - omRatisServer.checkLeaderStatus(); + omRatisServer.getLeaderStatus(); RaftPeerId raftPeerId = omRatisServer.getRaftPeerId(); switch (raftServerStatus) { diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java index d90c5ffce452..afa3151a8c3e 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java @@ -357,7 +357,6 @@ public void addOMToRatisRing(OMNodeDetails newOMNode) throws IOException { final List newPeersList = new ArrayList<>(raftPeerMap.values()); newPeersList.add(newRaftPeer); - checkLeaderStatus(); SetConfigurationRequest request = new SetConfigurationRequest(clientId, server.getId(), raftGroupId, nextCallId(), newPeersList); @@ -390,7 +389,6 @@ public void removeOMFromRatisRing(OMNodeDetails removeOMNode) .map(Map.Entry::getValue) .collect(Collectors.toList()); - checkLeaderStatus(); SetConfigurationRequest request = new SetConfigurationRequest(clientId, server.getId(), raftGroupId, nextCallId(), newPeersList); @@ -829,7 +827,7 @@ public enum RaftServerStatus { * * @return RaftServerStatus. */ - public RaftServerStatus checkLeaderStatus() { + public RaftServerStatus getLeaderStatus() { final RaftServer.Division division = getServerDivision(); if (division == null) { return RaftServerStatus.NOT_LEADER; diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java index 6b7bccd4ab9d..1cf6c1d5690c 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java @@ -186,7 +186,7 @@ public OMRequest getLastRequestToSubmit() { private OMResponse submitReadRequestToOM(OMRequest request) throws ServiceException { // Check if this OM is the leader. - RaftServerStatus raftServerStatus = omRatisServer.checkLeaderStatus(); + RaftServerStatus raftServerStatus = omRatisServer.getLeaderStatus(); if (raftServerStatus == LEADER_AND_READY || request.getCmdType().equals(PrepareStatus)) { return handler.handleReadRequest(request); diff --git a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/OmTestManagers.java b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/OmTestManagers.java index bbe6decd879c..c2cf77fb8033 100644 --- a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/OmTestManagers.java +++ b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/OmTestManagers.java @@ -122,7 +122,7 @@ public OmTestManagers(OzoneConfiguration conf, "scmTopologyClient", scmTopologyClient); om.start(); - waitFor(() -> om.getOmRatisServer().checkLeaderStatus() == RaftServerStatus.LEADER_AND_READY, + waitFor(() -> om.getOmRatisServer().getLeaderStatus() == RaftServerStatus.LEADER_AND_READY, 10, 10_000); rpcClient = OzoneClientFactory.getRpcClient(conf);