diff --git a/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java b/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java index 60b2598a50a7..f35141d68aae 100644 --- a/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java +++ b/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java @@ -44,7 +44,6 @@ import jakarta.annotation.Nonnull; import jakarta.annotation.Nullable; import java.io.File; -import java.io.IOException; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; import java.net.InetSocketAddress; @@ -90,7 +89,6 @@ import org.apache.hadoop.security.token.SecretManager; import org.apache.ratis.thirdparty.com.google.protobuf.ByteString; import org.apache.ratis.util.SizeInBytes; -import org.apache.ratis.util.function.CheckedSupplier; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -821,25 +819,6 @@ public static String threadNamePrefix(@Nullable Object id) { : ""; } - /** - * Execute some code and ensure thread name is not changed - * (workaround for HADOOP-18433). - */ - public static T preserveThreadName( - CheckedSupplier supplier) throws E { - final Thread thread = Thread.currentThread(); - final String threadName = thread.getName(); - - try { - return supplier.get(); - } finally { - if (!Objects.equals(threadName, thread.getName())) { - LOG.info("Restoring thread name: {}", threadName); - thread.setName(threadName); - } - } - } - /** * Transform a protobuf UUID to Java UUID. */ diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeClientProtocolServer.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeClientProtocolServer.java index 1613e0467bb3..623587dd33b4 100644 --- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeClientProtocolServer.java +++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeClientProtocolServer.java @@ -22,7 +22,6 @@ import static org.apache.hadoop.hdds.HddsConfigKeys.HDDS_DATANODE_HANDLER_COUNT_KEY; import static org.apache.hadoop.hdds.HddsConfigKeys.HDDS_DATANODE_READ_THREADPOOL_DEFAULT; import static org.apache.hadoop.hdds.HddsConfigKeys.HDDS_DATANODE_READ_THREADPOOL_KEY; -import static org.apache.hadoop.hdds.HddsUtils.preserveThreadName; import static org.apache.hadoop.hdds.protocol.DatanodeDetails.Port.Name.CLIENT_RPC; import com.google.protobuf.BlockingService; @@ -114,8 +113,8 @@ private RPC.Server getRpcServer(OzoneConfiguration configuration, .ReconfigureProtocolService.newReflectiveBlockingService( reconfigureServerProtocol); - return preserveThreadName(() -> startRpcServer(configuration, rpcAddress, - ReconfigureProtocolDatanodePB.class, reconfigureService, handlerCount, readThreads)); + return startRpcServer(configuration, rpcAddress, + ReconfigureProtocolDatanodePB.class, reconfigureService, handlerCount, readThreads); } /** diff --git a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java index 7719742d35bb..cd8da86f7e4c 100644 --- a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java +++ b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java @@ -17,7 +17,6 @@ package org.apache.hadoop.hdds.scm.server; -import static org.apache.hadoop.hdds.HddsUtils.preserveThreadName; import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_EVENT_REPORT_EXEC_WAIT_THRESHOLD_DEFAULT; import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_EVENT_REPORT_QUEUE_WAIT_THRESHOLD_DEFAULT; import static org.apache.hadoop.hdds.scm.ScmUtils.checkIfCertSignRequestAllowed; @@ -1093,7 +1092,7 @@ public static RPC.Server startRpcServer( int readThreads) throws IOException { - RPC.Server rpcServer = preserveThreadName(() -> new RPC.Builder(conf) + RPC.Server rpcServer = new RPC.Builder(conf) .setProtocol(protocol) .setInstance(instance) .setBindAddress(addr.getHostString()) @@ -1102,7 +1101,7 @@ public static RPC.Server startRpcServer( .setNumReaders(readThreads) .setVerbose(false) .setSecretManager(null) - .build()); + .build(); HddsServerUtil.addPBProtocol(conf, protocol, instance, rpcServer); return rpcServer; diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java index 35d5169da97f..b758bb8e2fc1 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java @@ -22,7 +22,6 @@ import static org.apache.hadoop.hdds.HddsConfigKeys.HDDS_BLOCK_TOKEN_ENABLED; import static org.apache.hadoop.hdds.HddsConfigKeys.HDDS_BLOCK_TOKEN_ENABLED_DEFAULT; import static org.apache.hadoop.hdds.HddsUtils.getScmAddressForClients; -import static org.apache.hadoop.hdds.HddsUtils.preserveThreadName; import static org.apache.hadoop.hdds.server.ServerUtils.updateRPCListenAddress; import static org.apache.hadoop.hdds.utils.HAUtils.getScmInfo; import static org.apache.hadoop.hdds.utils.HddsServerUtil.getRemoteUser; @@ -1312,7 +1311,7 @@ private RPC.Server startRpcServer(OzoneConfiguration conf, final int readThreads = conf.getInt(OZONE_OM_READ_THREADPOOL_KEY, OZONE_OM_READ_THREADPOOL_DEFAULT); - RPC.Server rpcServer = preserveThreadName(() -> new RPC.Builder(conf) + RPC.Server rpcServer = new RPC.Builder(conf) .setProtocol(OzoneManagerProtocolPB.class) .setInstance(clientProtocolService) .setBindAddress(addr.getHostString()) @@ -1321,7 +1320,7 @@ private RPC.Server startRpcServer(OzoneConfiguration conf, .setNumReaders(readThreads) .setVerbose(false) .setSecretManager(delegationTokenMgr) - .build()); + .build(); HddsServerUtil.addPBProtocol(conf, OMInterServiceProtocolPB.class, interOMProtocolService, rpcServer);