From 78b837755388208c087b09e563ef9ec5d94c3a6f Mon Sep 17 00:00:00 2001 From: chungen0126 Date: Wed, 9 Oct 2024 18:24:05 +0800 Subject: [PATCH 1/4] HDDS-11486. SnapshotDiffManager prints ERROR for NativeLibraryNotLoadedException --- .../apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java index db6d9b7b9084..8b51552bb002 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java @@ -284,7 +284,8 @@ private boolean initNativeLibraryForEfficientDiff(final OzoneConfiguration conf) try { return ManagedRawSSTFileReader.loadLibrary(); } catch (NativeLibraryNotLoadedException e) { - LOG.error("Native Library for raw sst file reading loading failed.", e); + LOG.warn("Native Library for raw sst file reading loading failed." + + " Fallback to Handling raw sst file by deltas", e); return false; } } From 159e0ca805f608bffea5b7bc43f0ad1bfa19da0c Mon Sep 17 00:00:00 2001 From: chungen0126 Date: Wed, 9 Oct 2024 18:50:09 +0800 Subject: [PATCH 2/4] omit the trace stack --- .../apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java index 8b51552bb002..190cb02dbe39 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java @@ -285,7 +285,7 @@ private boolean initNativeLibraryForEfficientDiff(final OzoneConfiguration conf) return ManagedRawSSTFileReader.loadLibrary(); } catch (NativeLibraryNotLoadedException e) { LOG.warn("Native Library for raw sst file reading loading failed." + - " Fallback to Handling raw sst file by deltas", e); + " Fallback to Handling raw sst file by deltas"); return false; } } From 5a75ec46c2195ed9076561d98f78013faab52f17 Mon Sep 17 00:00:00 2001 From: chungen0126 Date: Wed, 9 Oct 2024 19:15:55 +0800 Subject: [PATCH 3/4] keep exception but omit stack trace --- .../apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java index 190cb02dbe39..53b3de13c208 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java @@ -285,7 +285,7 @@ private boolean initNativeLibraryForEfficientDiff(final OzoneConfiguration conf) return ManagedRawSSTFileReader.loadLibrary(); } catch (NativeLibraryNotLoadedException e) { LOG.warn("Native Library for raw sst file reading loading failed." + - " Fallback to Handling raw sst file by deltas"); + " Fallback to Handling raw sst file by deltas. {}", e.getMessage()); return false; } } From f0d4b1c75a1df3431c0c39721d486a6be0e05332 Mon Sep 17 00:00:00 2001 From: chungen0126 Date: Thu, 10 Oct 2024 03:20:39 +0800 Subject: [PATCH 4/4] address comment --- .../apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java index 53b3de13c208..6393f12066c4 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java @@ -285,7 +285,7 @@ private boolean initNativeLibraryForEfficientDiff(final OzoneConfiguration conf) return ManagedRawSSTFileReader.loadLibrary(); } catch (NativeLibraryNotLoadedException e) { LOG.warn("Native Library for raw sst file reading loading failed." + - " Fallback to Handling raw sst file by deltas. {}", e.getMessage()); + " Fallback to performing a full diff instead. {}", e.getMessage()); return false; } }