From 18166c4d5925211b611703f70c29cac9b83ea03c Mon Sep 17 00:00:00 2001
From: Aswin Shakil Balasubramanian <aswin.shakil47@gmail.com>
Date: Thu, 27 Jul 2023 09:50:24 -0700
Subject: [PATCH] HDDS-9090. NullPointerException thrown by
 ReplicationManagerMetrics because of the order of initialization

---
 .../hdds/scm/container/replication/ReplicationManager.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java
index d1d8a3782bf7..4974407f363a 100644
--- a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java
+++ b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java
@@ -243,6 +243,7 @@ public ReplicationManager(final ConfigurationSource conf,
     this.ratisReplicationCheckHandler =
         new RatisReplicationCheckHandler(ratisContainerPlacement);
     this.nodeManager = nodeManager;
+    this.metrics = ReplicationManagerMetrics.create(this);
 
     ecUnderReplicationHandler = new ECUnderReplicationHandler(
         ecContainerPlacement, conf, this);
@@ -285,7 +286,6 @@ public synchronized void start() {
     if (!isRunning()) {
       LOG.info("Starting Replication Monitor Thread.");
       running = true;
-      metrics = ReplicationManagerMetrics.create(this);
       if (rmConf.isLegacyEnabled()) {
         legacyReplicationManager.setMetrics(metrics);
       }