From 68e6e9fa03d013bd33b1371e99d657b95b4130a3 Mon Sep 17 00:00:00 2001 From: Swaminathan Balachandran Date: Fri, 30 Jun 2023 00:02:33 -0700 Subject: [PATCH 1/2] HDDS-7794: [snapshot] SnapshotDiff should throw better error messages for exception handling --- .../org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java index f78c6e064517..858ebd8fdac5 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java @@ -70,7 +70,8 @@ public static SnapshotInfo getSnapshotInfo(final OzoneManager ozoneManager, throw e; } if (snapshotInfo == null) { - throw new OMException(KEY_NOT_FOUND); + throw new OMException("Snapshot '"+ snapshotKey +"' is not found.", + KEY_NOT_FOUND); } return snapshotInfo; } From f6baab80d5c09bbe265e7edf01ba1d7a0432a86f Mon Sep 17 00:00:00 2001 From: Swaminathan Balachandran Date: Fri, 30 Jun 2023 00:14:32 -0700 Subject: [PATCH 2/2] HDDS-7794: Fix checkstyle --- .../java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java index 858ebd8fdac5..de6ab46361a1 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java @@ -70,7 +70,7 @@ public static SnapshotInfo getSnapshotInfo(final OzoneManager ozoneManager, throw e; } if (snapshotInfo == null) { - throw new OMException("Snapshot '"+ snapshotKey +"' is not found.", + throw new OMException("Snapshot '" + snapshotKey + "' is not found.", KEY_NOT_FOUND); } return snapshotInfo;