From 60fb40b2d3a30d02699f159bd3489b2371ac7f64 Mon Sep 17 00:00:00 2001 From: sky76093016 <6ssssssky6@gmail.com> Date: Wed, 30 Jun 2021 11:55:01 +0800 Subject: [PATCH 1/2] HDDS-5396. Fix potential IndexOutOfBoundsException in MockCRLStore.java --- .../org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java index 0e2851e3df0d..0135892c2471 100644 --- a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java +++ b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java @@ -106,7 +106,7 @@ public Optional revokeCert(List certs, List crlInfos = scmCertStore.getCrls(ImmutableList.of(crlId.get())); - if (crlInfos.isEmpty()) { + if (crlInfos == null || crlInfos.isEmpty()) { log.debug("CRL[0]: {}", crlInfos.get(0)); } return crlId; From 3350565da68622afe0c55b724e484795db3ea858 Mon Sep 17 00:00:00 2001 From: sky76093016 <6ssssssky6@gmail.com> Date: Wed, 30 Jun 2021 13:13:53 +0800 Subject: [PATCH 2/2] Modify if condition --- .../org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java index 0135892c2471..1311a17e9f53 100644 --- a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java +++ b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/update/server/MockCRLStore.java @@ -106,7 +106,7 @@ public Optional revokeCert(List certs, List crlInfos = scmCertStore.getCrls(ImmutableList.of(crlId.get())); - if (crlInfos == null || crlInfos.isEmpty()) { + if (!crlInfos.isEmpty()) { log.debug("CRL[0]: {}", crlInfos.get(0)); } return crlId;