Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[QA] why not all examples run out of the box? #5717

Open
matt32106 opened this issue Apr 6, 2017 · 12 comments
Open

[QA] why not all examples run out of the box? #5717

matt32106 opened this issue Apr 6, 2017 · 12 comments

Comments

@matt32106
Copy link

matt32106 commented Apr 6, 2017

In the last three months, i have tried several examples in R or python, with a number of versions of mxnet. Very often, the examples throw errors of one kind or another when you run them 'as is'.

Do you think it would be possible to make sure all examples run before accepting a PR?
In fact, why not use the various examples as test cases where results could be checked against expected values (using fixed seeds)?

Open issues with examples problems:

@matt32106 matt32106 changed the title [QA] why all examples don't run out of the box? [QA] why not all examples run out of the box? Apr 6, 2017
@Bumblebee1964
Copy link

One important reason seems to me that documentation is not available or out-dated.

For instance the info on C++ API on mxnet,io can be considered as obsolete. The older version of this API had at least a VS solution and a complete set of header files so you can see how to build a working sample. On the latest version of the C++ API there is no VS solution anymore so you have to find out everything by trial and error (oruse the old version and copy relevant settings).

For us, users, it is kind of free so I do not like to complain. But if there is time and/or budget for the maintainers, some more up-to-date and less cryptic documentation would at least attract more people from SME's. It is for me hard to defend it took weeks to get a bare working MxNet with C++ interface on a Win10 system with a Titan X Board .

@szha
Copy link
Member

szha commented Sep 29, 2017

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!

@szha szha closed this as completed Sep 29, 2017
@matt32106
Copy link
Author

I think this issue is still alive...

@szha szha reopened this Sep 29, 2017
@data4science
Copy link

Has anyone looked at example code compatibility with mxnet-mkl & Python 3.6? I'm willing to if not.

@eric-haibin-lin
Copy link
Member

@data4science thanks that will be a great help!

@data4science
Copy link

data4science commented Oct 2, 2017

@matt32106 @eric-haibin-lin sounds good. My daily driver is MacOS, so I'm building from source. Let me know if anyone wants the resulting build. Then I'll go through the example code with Linux (Ubuntu 16.04, unless someone has a different distribution request). Does it mater if the Linux run is local or on a VPS (prob. AWS).

Assuming the example code works, I'll benchmark with the provided benchmark examples. Then I'll make a CSV file with columns for standard BLAS, MKL BLAS, & % improvement where rows are individual images. Finally, I'll create a visualization (type determined by data).

Does this sound like a decent plan of attack, or is MacOS build a bit unnecessary (heavy loads would likely be on VPS or cluster)?

@Bumblebee1964
Copy link

Great of you can make time to do this effort. Personally I am interested in c++ examples getting to work. Once I finished my adjusted version of InceptionBN in C++ (changing last layers, showing how to predict images in batch without the predict interface) l will contribute this.

@eric-haibin-lin
Copy link
Member

eric-haibin-lin commented Nov 17, 2017

@Bumblebee1964 any update for the cpp examples? :)
Someone is asking about batch mode in cpp https://discuss.mxnet.io/t/c-api-batch-mode/253/1

@data4science
Copy link

@eric-haibin-lin Sorry I got side tracked from the MKL examples. I’ll re-focus on them.

@data4science
Copy link

Skipping the MacOS and going straight to VPS btw. @eric-haibin-lin should the image include gpu(s)? My thought is no since MKL is optimized for Intel CPUs. Please recommend VPS image specs for benchmarking.

@Bumblebee1964
Copy link

Thanks @eric-haibin-lin for notifying me about https://discuss.mxnet.io/t/c-api-batch-mode/253/1 I will answer this thread later this week.

I have not yet figured out how to publish a sample on github and last weeks busy figuring out how to compile mxnet 0.11 with cpp-package and GPU support, which I recently accomplished.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants