Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Website] Clipboard button display issue + doesn't function correctly + Tutorials Page gets clipped horizontally #18693

Open
ChaiBapchya opened this issue Jul 11, 2020 · 5 comments

Comments

@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Jul 11, 2020

Description

Page: https://mxnet.apache.org/api/python/docs/tutorials/deploy/export/onnx.html

Issue 1:

Copy button isn't shown properly. I guess it's supposed to show a clipboard or something written on Copy instead of grey small square button
Screen Shot 2020-07-10 at 5 22 17 PM

Browser

Only seen in Firefox
Moreover, this button isn't visible on Safari/Chrome.

Issue 2: Page Clipped horizontally

When the browser is not in full-size
Table of contents gets clipped
Screen Shot 2020-07-10 at 5 28 38 PM

After elongating the browser, it shows the complete text of Table of contents
Screen Shot 2020-07-10 at 5 29 03 PM

Moreover, it isn't even scrollable so only way to see the entire text is to drag the browser window to the right.

Browser

Across Safari, Chrome, Firefox

Solution: Make the page reactive so that irrespective of the size of the page, it fits well.

To Reproduce

Page: https://mxnet.apache.org/api/python/docs/tutorials/deploy/export/onnx.html

What have you tried to solve it?

  1. Changed the browser [Firefox, Safari, Chrome]
  2. Reloaded the cache
@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [website]

@ChaiBapchya ChaiBapchya changed the title [Website] Clipboard option not displayed properly & Page gets clipped horizontally [Website] Clipboard button not displayed properly & Page gets clipped horizontally Jul 11, 2020
@ChaiBapchya ChaiBapchya changed the title [Website] Clipboard button not displayed properly & Page gets clipped horizontally [Website] Clipboard button display issue + doesn't function correctly + Tutorials Page gets clipped horizontally Jul 28, 2020
@ChaiBapchya
Copy link
Contributor Author

Issue 3

https://mxnet.apache.org/versions/1.6/get_started/build_from_source
Copy button exists in this page. But it doesn't actually work. Unable to paste from the clipboard.

Browsers: Safari, Firefox, Chrome

@ys2843
Copy link
Contributor

ys2843 commented Jul 28, 2020

Issue 3

https://mxnet.apache.org/versions/1.6/get_started/build_from_source
Copy button exists in this page. But it doesn't actually work. Unable to paste from the clipboard.

Browsers: Safari, Firefox, Chrome

For main site, please clean the cache in browser and try again. Because there are some changes recently made to clip board in v1.6 website.

@ChaiBapchya
Copy link
Contributor Author

ChaiBapchya commented Jul 28, 2020

Cleaning the cache didn't quite help. Can you verify?

@ys2843
Copy link
Contributor

ys2843 commented Jul 28, 2020

Root cause: a regex in copycode.js is only supported in Chrome currently, but not safari and firefox. Will fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants