Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Profiler: Operator Aggregate Stats Duplication #15243

Closed
Zha0q1 opened this issue Jun 13, 2019 · 2 comments · Fixed by #15240
Closed

Profiler: Operator Aggregate Stats Duplication #15243

Zha0q1 opened this issue Jun 13, 2019 · 2 comments · Fixed by #15240
Labels
Bug Profiler MXNet profiling issues

Comments

@Zha0q1
Copy link
Contributor

Zha0q1 commented Jun 13, 2019

When call profiler.dumps(), operators' call count is 2x the actual value.

This is because in ProfileOperator class in profiler.h, we are profiling a single operator call both as operator and as task (i.e. generating two events in the dump file for each operator call). However, in AggregateStats, we are simply mapping operator names to its stats. We should be a duplication check somewhere.

Screen Shot 2019-06-13 at 12 57 08 PM

@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Feature

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Jun 13, 2019

I have created a PR to fix this: #15240

@Zha0q1 Zha0q1 changed the title Operator Aggregate Stats Duplication Profiler: Operator Aggregate Stats Duplication Jun 13, 2019
@zachgk zachgk added Bug Profiler MXNet profiling issues labels Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Profiler MXNet profiling issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants