Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Build]Integrate compile to cmake as only, remove makefile #14820

Open
NeoZhangJianyu opened this issue Apr 28, 2019 · 4 comments
Open

[Build]Integrate compile to cmake as only, remove makefile #14820

NeoZhangJianyu opened this issue Apr 28, 2019 · 4 comments
Labels
Build CMake CMake related bugs/issues/improvements Makefile

Comments

@NeoZhangJianyu
Copy link
Contributor

Description

MXNet provide CMakelist.txt and Makefile in same time to compile.
It's hard to maintain two compile systems, please integrate to cmake as only.

cmake support build MXNet in all OS (windows, linux, mac) , makefile is only support non-windows.

We meet trouble that makefile is updated for new code, but CMakelist.txt is missed to update for the new code.
So the cmake is broken in linux and windows. And the CI doesn't find such error.
Refer to #14492

Environment info (Required)

Linux and Windows.

Package used (Python/R/Scala/Julia):
NA

Build info (Required if built from source)

Compiler (gcc/clang/mingw/visual studio):
All.

MXNet commit hash:
git rev-parse HEAD
1c49e40

Build config:
NA

Error Message:

NA

Minimum reproducible example

NA

Steps to reproduce

NA

What have you tried to solve it?

Remove Makefile in MXNet project.
User only use cmake to build the MXNet.

@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Build

@pengzhao-intel
Copy link
Contributor

@NeoZhangJianyu NeoZhangJianyu changed the title Integrate compile to cmake as only, remove makefile [Build]Integrate compile to cmake as only, remove makefile Apr 28, 2019
@KellenSunderland
Copy link
Contributor

I'd propose we have two votes on dropping Makefile. One vote for dropping support in the next major version (2.0), one vote for dropping support in an upcoming minor version (either 1.5 or 1.6).

@lanking520 lanking520 added Build CMake CMake related bugs/issues/improvements Makefile labels Apr 29, 2019
@larroy
Copy link
Contributor

larroy commented May 1, 2019

@KellenSunderland happy to ditch Make, unfortunately Jetson doesn't build with CMake due to CUDA and cross compilation complications. We are using your work to (cross)compile for Jetson.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build CMake CMake related bugs/issues/improvements Makefile
Projects
None yet
Development

No branches or pull requests

6 participants