Install page history broken

[zachgk]

Description

On the website install page, there are buttons to select the installation configuration. When you click those buttons, it changes your browser history. But, if you press the browser back button, it won't change the displayed contents or update the page to the previous configuration. For the same reason, it does not react to the forward button as well.

[mxnet-label-bot]

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Doc

[zachgk]

@mxnet-label-bot add [Website, Bug]

[aaronmarkham]

@zachgk Is this still an issue on the new site?

[zachgk]

@aaronmarkham This issue is still there. To reproduce,

1. go to the installation docs on the get_started page.
2. Randomly click on any of the buttons. Note that it changes the url path to index.html which is also wrong.
3. If you press the browser back button, it doesn't do anything. If you press it repeatedly, it only takes effect if you press it more than the number of times you changed the installation options.

You can see the relevant code here. There are two ways to resolve this problem:

1. We simply don't use the history api and delete all occurrences of history.pushState. Then, the back button will simply leave the get_started page.
2. We handle the history popstate event so that presses to the back (and I believe forward) button are handled and will switch to the previously selected options. There may be other things to fix to get this working as well (especially due to the new site).

[aaronmarkham]

Sheng fixed this on the new site.

[zachgk]

I think Sheng fixed a different problem. I just checked and this problem still occurs

[ys2843]

@aaronmarkham This bug is still reproducible on new website, can I work on this?

[ys2843]

@aaronmarkham This issue was resolved. We can close it.

[zachgk]

Thanks @ys2843. Fixed in #18182