Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Makefile plugins target needs mkldnn dependency #14236

Closed
samskalicky opened this issue Feb 22, 2019 · 7 comments · Fixed by #14274
Closed

Makefile plugins target needs mkldnn dependency #14236

samskalicky opened this issue Feb 22, 2019 · 7 comments · Fixed by #14274

Comments

@samskalicky
Copy link
Contributor

Description

Building MXNet from source and enabling the WarpCTC plugin following these instructions:
https://github.com/apache/incubator-mxnet/tree/master/example/ctc#ctc-loss-in-mxnet
fails to build on Ubuntu with make -j$nproc because it depends on mkldnn which wasnt compiled yet. This is due to a missing makefile dependency on the plugin build target.

Heres the error message:

In file included from include/mxnet/./op_attr_types.h:36:0,
                 from include/mxnet/operator.h:40,
                 from plugin/warpctc/./warpctc-inl.h:31,
                 from plugin/warpctc/warpctc.cc:27:
include/mxnet/././ndarray.h:41:22: fatal error: mkldnn.hpp: No such file or directory
 #include <mkldnn.hpp>
                      ^
compilation terminated.
make: *** [build/plugin/warpctc/warpctc.o] Error 1
@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Build

@frankfliu
Copy link
Contributor

@mxnet-label-bot add [Build, Bug]

@pengzhao-intel
Copy link
Contributor

Thanks to raising the issue. @xinyu-intel could you help take a look?

@pengzhao-intel
Copy link
Contributor

@mxnet-label-bot add [MKLDNN]

@rongzha1
Copy link
Contributor

@samskalicky you can workaround by using: make -j1

@samskalicky
Copy link
Contributor Author

Thanks guys!

Ive tried adding " | mkldnn " to the Makefile here:

https://github.com/apache/incubator-mxnet/blob/master/Makefile#L492

that seems to be working. This is similar to another target above:

https://github.com/apache/incubator-mxnet/blob/master/Makefile#L476

Any thoughts about committing this change into the makefile?

@apeforest
Copy link
Contributor

Why do we need warpctc if mxnet already has native implementation?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants