Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Backwards compatibility out of bounds for 1.2.1 #14234

Open
marcoabreu opened this issue Feb 22, 2019 · 9 comments
Open

Backwards compatibility out of bounds for 1.2.1 #14234

marcoabreu opened this issue Feb 22, 2019 · 9 comments

Comments

@marcoabreu
Copy link
Contributor

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-backwards-compatibility-checker/detail/restricted-backwards-compatibility-checker/380/pipeline

INFO:root:=================================

INFO:root:Fetching files for MXNet version : 1.2.1 and model lenet_gluon_hybrid_export_api

[06:36:44] src/nnvm/legacy_json_util.cc:209: Loading symbol saved by previous version v1.2.1. Attempting to upgrade...

[06:36:44] src/nnvm/legacy_json_util.cc:217: Symbol successfully upgraded!

Traceback (most recent call last):

  File "model_backwards_compat_inference.py", line 136, in <module>

    test_lenet_gluon_hybrid_imports_api()

  File "model_backwards_compat_inference.py", line 95, in test_lenet_gluon_hybrid_imports_api

    assert_almost_equal(old_inference_results.asnumpy(), output.asnumpy(), rtol=rtol_default, atol=atol_default)

  File "/work/mxnet/python/mxnet/test_utils.py", line 495, in assert_almost_equal

    raise AssertionError(msg)

AssertionError: 

Items are not equal:

Error 1962.383789 exceeds tolerance rtol=0.000010, atol=0.000010.  Location of maximum error:(15, 0), a=0.061246, b=0.040821

 a: array([[ 0.03364218,  0.24863665],

       [-0.03897328,  0.28473783],

       [ 0.00993963,  0.18869999],...

 b: array([[ 0.03364221,  0.24863653],

       [-0.03897329,  0.28473788],

       [ 0.00993963,  0.18870012],...

@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Bug

@frankfliu
Copy link
Contributor

frankfliu commented Feb 22, 2019

@mxnet-label-bot add [Bug]

@marcoabreu marcoabreu added the Bug label Feb 22, 2019
@piyushghai
Copy link
Contributor

@marcoabreu Haven't seen this failing again. Maybe something intermittently went in that broke it and now it seems to be fixed.
http://jenkins.mxnet-ci.amazon-ml.com/job/restricted-backwards-compatibility-checker/

Can this issue be closed ?

@marcoabreu
Copy link
Contributor Author

No, MXNet yields different results for the same input, so we should track down why.

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [CI]

@lebeg
Copy link
Contributor

lebeg commented Mar 26, 2019

Another failure:

http://jenkins.mxnet-ci.amazon-ml.com/job/restricted-backwards-compatibility-checker/420/console

INFO:root:Fetching files for MXNet version : 1.2.1 and model lenet_gluon_save_params_api
Traceback (most recent call last):
  File "model_backwards_compat_inference.py", line 135, in <module>
    test_lenet_gluon_load_params_api()
  File "model_backwards_compat_inference.py", line 72, in test_lenet_gluon_load_params_api
    assert_almost_equal(old_inference_results.asnumpy(), output.asnumpy(), rtol=rtol_default, atol=atol_default)
  File "/work/mxnet/python/mxnet/test_utils.py", line 495, in assert_almost_equal
    raise AssertionError(msg)
AssertionError: 
Items are not equal:
Error 9591.478516 exceeds tolerance rtol=0.000010, atol=0.000010.  Location of maximum error:(17, 0), a=-0.441335, b=-0.315189
 a: array([[-0.40397233, -0.19248717],
       [-0.34466907, -0.15791757],
       [-0.39881065, -0.2201823 ],...
 b: array([[-0.4039724 , -0.19248715],
       [-0.3446689 , -0.15791774],
       [-0.39881057, -0.22018239],...

Maybe this should be tracked separately as it's a different failure?

@lebeg
Copy link
Contributor

lebeg commented Mar 26, 2019

Created separate issue #14524

@lebeg
Copy link
Contributor

lebeg commented Mar 26, 2019

Probably this issue can be closed.

@vdantu
Copy link
Contributor

vdantu commented Mar 26, 2019

@mxnet-label-bot update [flaky, gluon, ci]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants