Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Can't build R-package from master since #13062 #13589

Open
jeremiedb opened this issue Dec 8, 2018 · 5 comments
Open

Can't build R-package from master since #13062 #13589

jeremiedb opened this issue Dec 8, 2018 · 5 comments

Comments

@jeremiedb
Copy link
Contributor

Commit #13062 by adding the symbolic links to dmlc and nnvm seems the cause of the error in building the R-package.
Thwe code in cause in the Makefile for rpkg are:

cp -rf 3rdparty/dmlc-core/include/* R-package/inst/include/
cp -rf 3rdparty/tvm/nnvm/include/* R-package/inst/include

If removing the above lines, the build of the R-package still fails. Seems like the symbollic like isn't resolved properly by the process (not too sure about this later part).

Shouldn't a build test have captured this issue?

@lanking520
Copy link
Member

Hi @jeremiedb , not sure how R build so I tagged someone who knows better than me. I think we do have R build procedure and it is here:
https://github.com/apache/incubator-mxnet/blob/master/ci/docker/runtime_functions.sh#L789-L802
However, I do not see R building procedure in the CI which I think this is a problem.
@anirudhacharya

@anirudhacharya
Copy link
Member

@jeremiedb indeed it should have. Also I notice the current recipe for building R-package in the Makefile has a few wrong commands like this

@marcoabreu do we still have R build and tests running on the CI?

@marcoabreu
Copy link
Contributor

Yeah

@jeremiedb
Copy link
Contributor Author

I'll only be able to take a look in 2 days, and hopefully get it fixed.

@jeremiedb
Copy link
Contributor Author

@anirudhacharya Pull request #14068 should fix the those commands.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants