Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

MKLDNN int8 support #13516

Closed
azai91 opened this issue Dec 3, 2018 · 6 comments
Closed

MKLDNN int8 support #13516

azai91 opened this issue Dec 3, 2018 · 6 comments

Comments

@azai91
Copy link
Contributor

azai91 commented Dec 3, 2018

MKLDNN 0.17 release states that it supports int8 quantization (https://github.com/intel/mkl-dnn/releases). However, we run into the following issue when we comment out this line

mxnet.base.MXNetError: [15:57:38] src/operator/nn/mkldnn/mkldnn_convolution.cc:140: Check failed: conv_pd.next_impl() No implementation

To reach this, I had to comment out this line of code:
(https://github.com/apache/incubator-mxnet/blob/5111b187e3d8917d45a2482ceaf44b42588eff51/src/operator/subgraph/mkldnn/mkldnn_conv.cc#L346).

For Q & A and discussion, please start a discussion thread at https://discuss.mxnet.io

Description

(Brief description of the problem in no more than 2 sentences.)

Environment info (Required)

What to do:
1. Download the diagnosis script from https://raw.githubusercontent.com/apache/incubator-mxnet/master/tools/diagnose.py
2. Run the script using `python diagnose.py` and paste its output here.

Package used (Python/R/Scala/Julia):
(I'm using ...)

For Scala user, please provide:

  1. Java version: (java -version)
  2. Maven version: (mvn -version)
  3. Scala runtime if applicable: (scala -version)

For R user, please provide R sessionInfo():

Build info (Required if built from source)

Compiler (gcc/clang/mingw/visual studio):

MXNet commit hash:
(Paste the output of git rev-parse HEAD here.)

Build config:
(Paste the content of config.mk, or the build command.)

Error Message:

(Paste the complete error message, including stack trace.)

Minimum reproducible example

(If you are using your own code, please provide a short script that reproduces the error. Otherwise, please provide link to the existing example.)

Steps to reproduce

(Paste the commands you ran that produced the error.)

  1. Pending
@azai91
Copy link
Contributor Author

azai91 commented Dec 3, 2018

@pengzhao-intel

@pengzhao-intel
Copy link
Contributor

@azai91 Thanks for raising the issues.
We already have the implementations in local and will PR soon (just wait a moment for r1.4 cut before).
@ZhennanQin

@azai91
Copy link
Contributor Author

azai91 commented Dec 7, 2018

@pengzhao-intel when is the ETA for the PR?

@pengzhao-intel
Copy link
Contributor

@azai91 we need more validation with the real workload since the int8 network is not too much in the hand.

@ZhennanQin
Copy link
Contributor

Corresponding PR is filed at: #13697

@TaoLv
Copy link
Member

TaoLv commented Feb 11, 2019

#13697 is merged. Closing this issue now.

@TaoLv TaoLv closed this as completed Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants