Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

AddVersion.py breaks the site output in a variety of ways #12524

Closed
aaronmarkham opened this issue Sep 11, 2018 · 4 comments
Closed

AddVersion.py breaks the site output in a variety of ways #12524

aaronmarkham opened this issue Sep 11, 2018 · 4 comments

Comments

@aaronmarkham
Copy link
Contributor

aaronmarkham commented Sep 11, 2018

Description

AddVersion.py does some pretty aggressive website modifications just before publishing the full website. It was already known to break on the install page, and now it seems it is responsible for #12168 and #11438. I created a PR to fix this issue by commenting out this one line:

outstr = str(content).replace('&lt;', '<').replace('&gt;', '>')

But this ended up stopping the versions dropdown from appearing in the final website output. Having the versions dropdown is more important right now than fixing a couple of render issues, so I've submitted a patch that reverts this change along with an update for site consistency: #12426

Browsing the intermediate outputs from this script, you can see things like <span class="gp">>>> </span>. That's with the line enabled. More research is required to fix this script, so it produces valid html and doesn't break the code block's usage of xml or other tags the require > or <.

Tracking here as well:
https://issues.apache.org/jira/browse/MXNET-987

@aaronmarkham aaronmarkham changed the title versions dropdown missing AddVersion.py breaks the site output in a variety of ways Sep 12, 2018
@kalyc
Copy link
Contributor

kalyc commented Sep 12, 2018

Thanks for submitting the issue @aaronmarkham
@mxnet-label-bot[Website, Build, Installation]

@kalyc
Copy link
Contributor

kalyc commented Sep 13, 2018

@aaronmarkham is this issue still persisting?

@aaronmarkham
Copy link
Contributor Author

Yes

@aaronmarkham
Copy link
Contributor Author

New website launch makes this a moot issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants